Add computer to Data initialization in core
#92
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `computer` argument from the config class was not correctly passed to the core `Data` class. This is fixed here.
|
This PR probably fails because localhost is not created as computer. @leclairm will add his contribution to pass the TODO: need to use aiida localhost fixture for this |
|
Will require aiidateam/aiida-shell#109 to work. |
|
Moved this change to #136 adding you as co-author. Hope that's OK, @agoscinski! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
computerargument from the config class was not correctly passed to the coreDataclass. This is fixed here.Note that aiida-shell has a bug when using
RemoteData. This will be fixed here aiidateam/aiida-shell#107