Fixed Cuda Stream Protocol#1123
Conversation
msimberg
left a comment
There was a problem hiding this comment.
Approved, but blocking because I think we need to synchronize with a proper GHEX release given that the goal is to have stable release for icon uenvs. I'd aim to do a GHEX 0.5.1 release tomorrow.
Thank you for looking into this and fixing it!
|
@philip-paul-mueller would you be able to test https://pypi.org/project/ghex/0.5.1/ on this PR (n.b. I managed to do the release the wrong way around, so it's now already officially on pypi, not test.pypi)? |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run distributed |
|
cscs-ci run default |
|
cscs-ci run extra |
|
@havogt Are you fine with merging the fix? |
In PR#980 introduced streams into the halo exchanges.
For this also
DEFAULT_STREAM, which models the default stream and implements the CUDA Stream Protocol.However, the original implementation identified as protocol version
1instead of version0.Because of a related bug in GHEX this error was hidden.
This PR fixes the Python implementation and also updates GHEX.