remove the duplication of fixtures

[yiluchen1066]

• Removed duplicate timeloop_diffusion_savepoint_exit (driver) and timeloop_diffusion_savepoint_exit_standalone (standalone_driver)
  fixtures that were identical to the shared savepoint_diffusion_exit in datatest.py
• Added a small linit fixture alias in both driver and standalone_driver to bridge the parametrized timeloop_diffusion_linit_exit name
  to the linit name expected by the shared fixture

[yiluchen1066]

cscs-ci run default

[yiluchen1066]

cscs-ci run distributed

[yiluchen1066]

cscs-ci run default

[yiluchen1066]

cscs-ci run distributed

[jcanton]

I'm not sure but: there already is a linit fixture in model/testing/datatest.py why not use that directly instead of the alias?

[yiluchen1066]

I'm not sure but: there already is a linit fixture in model/testing/datatest.py why not use that directly instead of the alias?

the linit fixture in datatest.py always return False. The driver and the standalone driver tests need to override that value via @pytest.mark.parameterize("timeloop_diffusion_linit_exit", ...). So I added this alias fixture to do this override. Withouth the alias, savepoint_diffusion_exit would use linit=False regardless of what timeloop_diffusion_linit_exit is set in the parametrize decorator.

[github-actions]

Mandatory Tests

Please make sure you run these tests via comment before you merge!

• cscs-ci run default
• cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

• cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

• cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

• cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

[yiluchen1066]

cscs-ci run default

[yiluchen1066]

cscs-ci run distributed

[jcanton]

I'm not sure but: there already is a linit fixture in model/testing/datatest.py why not use that directly instead of the alias?

the linit fixture in datatest.py always return False. The driver and the standalone driver tests need to override that value via @pytest.mark.parameterize("timeloop_diffusion_linit_exit", ...). So I added this alias fixture to do this override. Withouth the alias, savepoint_diffusion_exit would use linit=False regardless of what timeloop_diffusion_linit_exit is set in the parametrize decorator.

and it's not possible to change the linit fixture in datatest.py to return True/False?

[yiluchen1066]

I'm not sure but: there already is a linit fixture in model/testing/datatest.py why not use that directly instead of the alias?

the linit fixture in datatest.py always return False. The driver and the standalone driver tests need to override that value via @pytest.mark.parameterize("timeloop_diffusion_linit_exit", ...). So I added this alias fixture to do this override. Withouth the alias, savepoint_diffusion_exit would use linit=False regardless of what timeloop_diffusion_linit_exit is set in the parametrize decorator.

and it's not possible to change the linit fixture in datatest.py to return True/False?

technically it could be made parametrizable, but I think the issue is that linit in datatest.py serves as a default for all diffusion tests. Most diffusion tests expect linit=False (a normal timestep), and only a few specific tests override it to True via @pytest.mark.parametrize("linit", [True]). If we changed the linit fixture in datatest.py to return both True and False, it would affect every test that depends on it

[yiluchen1066]

cscs-ci run default

[jcanton]

nice! thanks for the cleanup and clarifications!