Skip to content

fix: 찜하기 삭제에 따른 dto 수정#307

Merged
gomx3 merged 1 commit into
developfrom
fix/#306-찜하기-기능-삭제에-따른-게시글-dto-수정
Jun 21, 2026

Hidden character warning

The head ref may contain hidden characters: "fix/#306-\ucc1c\ud558\uae30-\uae30\ub2a5-\uc0ad\uc81c\uc5d0-\ub530\ub978-\uac8c\uc2dc\uae00-dto-\uc218\uc815"
Merged

fix: 찜하기 삭제에 따른 dto 수정#307
gomx3 merged 1 commit into
developfrom
fix/#306-찜하기-기능-삭제에-따른-게시글-dto-수정

Conversation

@bingle625

Copy link
Copy Markdown
Contributor

🚀 Pull Request

Issue

관련 이슈를 태그해주세요

✨ Summary

이번 PR에서 어떤 변화가 있었는지 한 줄 요약해주세요.

  • 찜하기 기능 삭제에 따라 게시글 응답 DTO를 변경된 백엔드 스펙에 맞게 수정

📚 Details of Changes

주요 변경 사항을 bullet로 정리해주세요.

  • GetPostResponseDto에서 더 이상 내려오지 않는 numFavorite, isPostFavorite 필드 제거
  • PostResponseDtoisPostFavorite 필드 추가

🎯 Key points to review

  • 제거/추가된 필드를 참조하던 다른 코드가 없는지 확인

🧪 Test & Verification

  • Storybook UI 확인: N/A (타입/DTO 변경만 포함)
  • 타입 에러 없음 확인

📎 Additional Notes

  • 개발기간: 2026-06-19 ~ 2026-06-19

@bingle625 bingle625 requested a review from a team as a code owner June 19, 2026 08:07
@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
causw-v3-admin Ready Ready Preview, Comment Jun 19, 2026 8:10am
causw-v3-admin-dev Ready Ready Preview, Comment Jun 19, 2026 8:10am
causw-v3-web Ready Ready Preview, Comment Jun 19, 2026 8:10am
causw-v3-web-dev Ready Ready Preview, Comment Jun 19, 2026 8:10am

@github-actions github-actions Bot requested review from MlNTYS and kyh0726 June 19, 2026 08:07
@github-actions github-actions Bot added the D-3 label Jun 19, 2026
@bingle625 bingle625 self-assigned this Jun 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds .claude to .gitignore and updates post-related DTOs by removing favorite-related fields (numFavorite and isPostFavorite) from GetPostResponseDto. However, isPostFavorite was added to PostResponseDto in the changes. The reviewer correctly pointed out this inconsistency, suggesting that isPostFavorite should also be removed from PostResponseDto to align with the removal of the favorite feature.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

postId: string;
postImageUrls: string[];
writerNickname: string;
isPostFavorite: boolean;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

찜하기 기능이 삭제됨에 따라 GetPostResponseDto에서 isPostFavorite 필드가 제거되었습니다. 일관성을 위해 PostResponseDto에서도 isPostFavorite 필드를 제거해야 합니다.

@gomx3 gomx3 merged commit 357d87c into develop Jun 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] 찜하기 기능 삭제에 따른 게시글 DTO 수정

3 participants