Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a major version bump that enables direct SQL reading by default using the direct_sql_pandas materialization query parameter, which preserves data types better than the previous approach. This requires server version >= 5.13.0 and includes proper version checking with error messages for incompatible servers.
- Adds
direct_sql_pandas=Trueparameter to all materialization query methods by default - Implements server version constraint checking (>=5.13.0) with custom error messages
- Updates test expectations to match new server version requirements
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| caveclient/materializationengine.py | Adds direct SQL parameter to query methods and version constraints with error messaging |
| caveclient/base.py | Extends version compatibility decorator to support custom error messages |
| tests/test_materialization.py | Updates test expectations for new server version and adds compatibility error testing |
| tests/test_skeletons.py | Minor code formatting improvements |
| caveclient/skeletonservice.py | Code formatting improvements for error messages |
| caveclient/l2cache.py | Fixes missing comma in list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be a major version bump which will enable by default using the materialization query parameter which will avoid mangling types.