Address PR #335 review feedback: version compat, validation, error handling, tests#336
Merged
fcollman merged 2 commits intoskeleton_bulk_improvementsfrom Mar 14, 2026
Conversation
1. Bump version from 8.0.0 to 8.1.0 in pyproject.toml to match changelog 2. Add per-skeleton error handling in download_skeletons_with_token 3. Add @_check_version_compatibility(method_constraint=">=0.22.51") to get_cached_skeletons_bulk and get_skeleton_access_token 4. Remove redundant verbose_level from URL query params (keep in JSON body) 5. Add skeleton version validation via self.get_versions() to both new methods 6. Add comprehensive tests for all three new methods Co-authored-by: fcollman <[email protected]>
Copilot
AI
changed the title
[WIP] Respond to reviews of open pull request
Address PR #335 review feedback: version compat, validation, error handling, tests
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all 6 review comments from the Copilot reviewer on PR #335 (
skeleton_bulk_improvements).caveclient/skeletonservice.py@_check_version_compatibility(method_constraint=">=0.22.51")toget_cached_skeletons_bulkandget_skeleton_access_token— matches PR description's server requirement and prevents cryptic 404s on older serversself.get_versions()check to both methods, consistent with every other method in the class (get_bulk_skeletons,get_cache_contents, etc.)verbose_level: Remove from URL query params, keep only in JSON body — consistent withgenerate_bulk_skeletons_asyncand other POST methodsdownload_skeletons_with_token: Wrap per-skeleton download in try/except so one failure doesn't discard all results — matches pattern used inget_cached_skeletons_bulk(line 1041) andget_bulk_skeletons(line 756)pyproject.tomlversionandcurrent_versionfrom8.0.0→8.1.0to match changelogtests/test_skeletons.pyget_cached_skeletons_bulk(dict, swc, truncation, invalid format, invalid version),get_skeleton_access_token(success, invalid version), anddownload_skeletons_with_token(success, partial failure graceful handling)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.