[FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checkmarks are done. But with this sample file I am getting some memory leaks (in debug mode) -- error shown in here Command used: ./ccextractor ~/Downloads/cc/test_dtvcc.ts --autoprogram --out=ttxt --latin1 |
IshanGrover2004
changed the title
PunitLodha
force-pushed
the
1499-initialize-dtvcc-ds
branch
from
c3a9eb0 to
9493e5e
Compare
IshanGrover2004
force-pushed
the
1499-initialize-dtvcc-ds
branch
2 times, most recently
from
baaeadb to
fbc8aa3
Compare
|
@IshanGrover2004 is this working fine now, after fixing the memory leaks? |
Working fine for some samples @PunitLodha |
IshanGrover2004
force-pushed
the
1499-initialize-dtvcc-ds
branch
from
fbc8aa3 to
af42011
Compare
|
Is there something wrong with the CI for regression test result msg? @canihavesomecoffee @prateekmedia |
10 tasks
IshanGrover2004
force-pushed
the
1499-initialize-dtvcc-ds
branch
from
ca2185d to
e22215f
Compare
|
Some weeks before PR was ready. |
read consumes the dtvcc struct resulting the pointer drops immediately which we don't want
Code contains flushing the active decoders of `dtvcc_rust`
Code contains flushing the active decoders of `dtvcc_rust`
IshanGrover2004
force-pushed
the
1499-initialize-dtvcc-ds
branch
from
b3fcb1d to
294b9d9
Compare
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit a34ba0f...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 39e051b...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1499
Work to be done in this PR:
ccxr_dtvcc_init()in lib.rs and use this at all places wheredtvcc_init()is being called. (Probably add a new struct field to lib_cc_decode likedtvcc_rustand store Dtvcc there instead of using the dtvcc field)dtvcc_free()dec_ctxinstead of creating a new oneAdditionally to fix mp4 code flow:-