Skip to content

Fixes error message for read-only attributes #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixes error message for read-only attributes #420

wants to merge 7 commits into from

Conversation

jasonb5
Copy link
Contributor

@jasonb5 jasonb5 commented Aug 21, 2020

Fixes #408.

  • Adds new exception ReadOnlyKeyError.
  • Raises ReadOnlyKeyError when setting certain attributes on file-backed variable/dataset.
  • Fixes raising error when read-only attribute is present in source variable being written to a file.

@jasonb5 jasonb5 added this to the 3.1.6 milestone Aug 21, 2020
@jasonb5 jasonb5 requested review from muryanto1 and downiec August 28, 2020 22:05
@jasonb5 jasonb5 removed the request for review from muryanto1 February 24, 2021 04:43
@jasonb5
Copy link
Contributor Author

jasonb5 commented Feb 24, 2021

@downiec This should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@downiec downiec Awaiting requested review from downiec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.6
Development

Successfully merging this pull request may close these issues.

cdms2 does not like a 'dimensions' variable attribute !
1 participant
@jasonb5