Skip to content

CTHLU-56 - clean up kafka topic config#723

Draft
adaball wants to merge 9 commits intomainfrom
ab/cthlu-56/kafka-config
Draft

CTHLU-56 - clean up kafka topic config#723
adaball wants to merge 9 commits intomainfrom
ab/cthlu-56/kafka-config

Conversation

@adaball
Copy link
Copy Markdown
Contributor

@adaball adaball commented Mar 27, 2026

Description

In working on CTHLU-56 I noticed that there was a fair number of duplicate config entries for Kafka topic names when porting over post-processing-service. In order to eliminate duplicates I went ahead and standardized the Kafka topic configuration keys organizing around the topic prefixes:

  • elastic_*
  • nbs_*
  • nrt_*

Given the high number of Kafka topics I wanted to make sure that I verified every one and ensured that the actual topic name wasn't lost in the shuffle. To do that I wrote a script to parse the application.yaml and output a CSV which I used to create the following spreadsheet that I used to go topic by topic:

https://docs.google.com/spreadsheets/d/12RyCBvzYOP7YwFs5qrSGdfBOv9KoymOV2-CdqFwmai4/edit?usp=sharing

This PR represents 47 of the topics, leaving out the topics for post-processing-service that will be handled in the main CTHLU-56 PR.

Related Issue

Jira Ticket

Additional Notes

  • Each key created uses the full Kafka topic name and while that makes the keys a bit long in some cases it makes very clear which topic is being referenced
  • This PR also standardizes the ENV shell variable names for the Kafka topics

Checklist

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.

Ada Ball added 8 commits March 27, 2026 10:19
Since this branch is separate from the branch where I'm
consolidating the `post-processing-service` I'm not going
to do its config update in this branch.

Ideally this branch will merge prior to `ab/cthlu-56/consolidate-post-processing`
so in that branch I can then merge the changes and transfer
over the `post-processing-service` kafka topic configs
@adaball adaball requested a review from a team March 27, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant