Skip to content

Add LCDDRVCE library #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add LCDDRVCE library #593

wants to merge 5 commits into from

Conversation

calc84maniac
Copy link
Contributor

Now you can do wacky LCD commands and stuff

I'd like some feedback on the API and docs, if possible. I consider the library implementation itself and its exported API to be more-or-less set in stone at this point, but the convenience macros can be changed as much as needed before merging.

I'm considering removing the bitfield-based raw parameter structs now that I've added parameter constants for most of the relevant commands. Though, that does bring to mind that we're missing a good way to define gamma parameters in C. Of course, that can be added later if needed.

@mateoconlechuga
Copy link
Member

This looks good to me

@mateoconlechuga mateoconlechuga marked this pull request as ready for review May 21, 2025 21:29
@adriweb
Copy link
Member

adriweb commented May 22, 2025

I've tried the two test programs on a few calcs:

  • 82AEP (rev pre-A): both work fine
  • 84+CET (rev A): both work fine
  • 83PCE (rev A): both work fine
  • 83PCE (rev E): both work fine
  • 83PCE (rev L): both work fine
  • 83PCEEP (rev M): half-res works, gradient "freezes" during the grey part at the top. Extremely rarely it works fully.
  • 84+CEPy (rev S): [calc behaves as non-python] both work fine
  • 84+CEPy (rev S, another): half-res works, gradient works 80% of the time (sometimes it freezes in the middle of random colors, sometimes there's some black area on top)
  • 83PCEEP (rev O): half-res works, gradient "freezes" during the grey part at the top.
  • 83PCEEP (rev S): half-res works, gradient "freezes" during the grey part at the top. Sometimes there's a vertical random-color bar. Extremely rarely it works fully.

Two other tests were submitted by other people, and they were working fine on non-python M+ calcs. So something python-related is interfering.

Here's the rev O "freezing" (I can still blindly press [clear] then turn the calc off then back on, though)
CleanShot 2025-05-22 at 20 56 30@2x

@adriweb adriweb marked this pull request as draft May 28, 2025 06:58
@adriweb
Copy link
Member

adriweb commented May 28, 2025

(Marking as draft again because @calc84maniac was able to repro the python-related issue so he can investigate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants