Skip to content

version update : dev to main #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
limgahyun merged 3 commits into from
Aug 14, 2025
Merged

version update : dev to main #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8aa467b
[feat] Application 조회에 락 적용
choiseoji Aug 13, 2025
454d34f
[feat] 읽기 전용, 쓰기 전용 분리
choiseoji Aug 13, 2025
6b60d4c
Merge pull request #217 from choiseoji/main
limgahyun Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/ceos/backend/domain/application/helper/ApplicationHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,15 @@ public Application getApplicationById(Long id) {
});
}

public Application getApplicationByIdForUpdate(Long id) {
return applicationRepository
.findByIdWithPessimisticLock(id)
.orElseThrow(
() -> {
throw ApplicantNotFound.EXCEPTION;
});
}

public Application getApplicationByUuidAndEmail(String uuid, String email) {
return applicationRepository
.findByUuidAndEmail(uuid, email)
Expand Down
9 changes: 9 additions & 0 deletions src/main/java/ceos/backend/domain/application/repository/ApplicationRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@
import ceos.backend.domain.application.domain.Pass;
import ceos.backend.global.common.entity.Part;
import java.util.Optional;

import jakarta.persistence.LockModeType;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.Lock;
import org.springframework.data.jpa.repository.Query;
import org.springframework.data.repository.query.Param;

Expand Down Expand Up @@ -63,4 +66,10 @@ Page<Application> findAllByPartAndDocumentPassAndFinalPass(
@Param("convertedDocPass") Pass convertedDocPass,
@Param("convertedFinalPass") Pass convertedFinalPass,
PageRequest pageRequest);


@Lock(LockModeType.PESSIMISTIC_WRITE)
@Query("select a from Application a where a.id = :id")
Optional<Application> findByIdWithPessimisticLock(@Param("id") Long id);

}
6 changes: 3 additions & 3 deletions src/main/java/ceos/backend/domain/application/service/ApplicationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ public GetInterviewTime getInterviewTime(Long applicationId) {
public void updateInterviewTime(Long applicationId, UpdateInterviewTime updateInterviewTime) {
recruitmentValidator.validateBetweenStartDateDocAndResultDateDoc(); // 기간 검증
applicationValidator.validateExistingApplicant(applicationId); // 유저 검증
final Application application = applicationHelper.getApplicationById(applicationId);
final Application application = applicationHelper.getApplicationByIdForUpdate(applicationId);
applicationValidator.validateDocumentPassStatus(application); // 서류 통과 검증
final List<Interview> interviews = interviewRepository.findAll();
final String duration =
Expand All @@ -262,15 +262,15 @@ public void updateDocumentPassStatus(Long applicationId, UpdatePassStatus update
recruitmentValidator.validateBetweenStartDateDocAndResultDateDoc(); // 기간 검증
applicationValidator.validateExistingApplicant(applicationId); // 유저 검증

final Application application = applicationHelper.getApplicationById(applicationId);
final Application application = applicationHelper.getApplicationByIdForUpdate(applicationId);
application.updateDocumentPass(updatePassStatus.getPass());
}

@Transactional
public void updateFinalPassStatus(Long applicationId, UpdatePassStatus updatePassStatus) {
recruitmentValidator.validateBetweenResultDateDocAndResultDateFinal(); // 기간 검증
applicationValidator.validateExistingApplicant(applicationId); // 유저 검증
final Application application = applicationHelper.getApplicationById(applicationId);
final Application application = applicationHelper.getApplicationByIdForUpdate(applicationId);
applicationValidator.validateDocumentPassStatus(application); // 서류 통과 검증

application.updateFinalPass(updatePassStatus.getPass());
Expand Down