-
Notifications
You must be signed in to change notification settings - Fork 226
added "offSource" to adjust the position of X-ray source #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
defThu
wants to merge
19
commits into
CERN:master
Choose a base branch
from
defThu:offSource
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a parameter to enable different position of the source
added the offSource parameter
added offSource to enable different positions of X-ray source
added offSource
Enable different source positions by using offSource
Enable different source positions by using offSource
added offSource
added offSource
added offSource
add offSource
fix bug caused by offSource
fix bug caused by offSource
add offSource
|
Thanks! I'll have a good look at it sometime in the next couple of weeks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi AnderBiguri, I added a new pull request here as I further modified the .cu code of backprojection and fixed some bugs in the last pull request.
I checked the modified code and added a demo named "d025_OffsetSource" in the demo dir. The results of the demo looks good. For example, the difference image between the projection with and without source offset is:

And the reconstruction images are similar:( Left: reference image without source offset; Right: reconstruction image with 60 mm source offset)

Just recompile the code and run the demo you can also get these results. Do you think this is correct? Because it is hard for me to check all the cuda code, so I'm not sure if there is still minor but import parts I need to consider.
Yifan Deng