Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

api: fix get_preset_id for unknown aspect ratio #38

Closed
wants to merge 1 commit into from
Closed

api: fix get_preset_id for unknown aspect ratio #38

wants to merge 1 commit into from

Conversation

egabancho
Copy link
Member

@egabancho egabancho commented Feb 14, 2018 •
edited
Loading

addresses #37

@egabancho egabancho requested a review from zzacharo February 14, 2018 16:01
@coveralls
Copy link

coveralls commented Feb 14, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 90.816% when pulling 2bd42c6 on egabancho:37-fix-get-preset-id into 03d1e67 on CERNDocumentServer:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 90.816% when pulling 2bd42c6 on egabancho:37-fix-get-preset-id into 03d1e67 on CERNDocumentServer:master.

@egabancho
Copy link
Member Author

missing tests!

@zzacharo zzacharo mentioned this pull request Feb 21, 2018
Open
@egabancho
Copy link
Member Author

#40

@egabancho egabancho closed this Mar 2, 2018
@egabancho egabancho deleted the 37-fix-get-preset-id branch March 2, 2018 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zzacharo zzacharo zzacharo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egabancho @coveralls @zzacharo