webhooks: use closest aspect ratio to transcode #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egabancho
force-pushed
the
fix-aspect-ratio-transcode
branch
from
8251041 to
e0a3907
Compare
* When running the transcode task it can happen that the aspect ratio is not in the list and therefore needs to be change by the closest one. We call use the display_aspect_ratio to call several API function so it might be better to fix it from the beginning. NOTE: this is a hack until CERNDocumentServer/cds-sorenson#37 is fixed.
egabancho
force-pushed
the
fix-aspect-ratio-transcode
branch
from
e0a3907 to
65a4c23
Compare
zzacharo
approved these changes
Feb 7, 2018
ntarocco
approved these changes
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the transcode task it can happen that the aspect ratio is not in the list and therefore needs to be change by the closest one. We call use the display_aspect_ratio to call several API function so it might be better to fix it from the beginning.
NOTE: this is a hack until CERNDocumentServer/cds-sorenson#37 is fixed.