specify velocity parameter to calculate scale of the time delay histo…#511
Open
martynpclark wants to merge 1 commit intoCH-Earth:developfrom
Open
specify velocity parameter to calculate scale of the time delay histo…#511martynpclark wants to merge 1 commit intoCH-Earth:developfrom
martynpclark wants to merge 1 commit intoCH-Earth:developfrom
Conversation
Collaborator
Author
|
@h294liu -- returning to an old pull request. Can you provide an update on the progress of these developments? |
|
I am so sorry for not following up on this work! Sure, I am happy to
complete the test after submitting the pyviscous manuscript this week. Does
this work?
…On Wed, Jul 5, 2023 at 2:37 PM Martyn Clark ***@***.***> wrote:
@h294liu <https://github.com/h294liu> -- returning to an old pull
request. Can you provide an update on the progress of these developments?
—
Reply to this email directly, view it on GitHub
<#511 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRWYP7JGRCCUZPCXEHWJTLXOXF7VANCNFSM5TZTH5GA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
Author
|
Yes, all is perfect! Thanks so much Hongli!!! |
h294liu
reviewed
Aug 4, 2023
h294liu
left a comment
There was a problem hiding this comment.
I have tested and found that SUMMA run through these new codes without any problems. Yeah!
Test Setting Configurations
- Set subRouting as constVel in the "modelDecisions.txt" file.
- Add the following to "basinParamInfo.txt" file: routingVelocity | 1.00 | 0.1000 | 100.0000
Note that the three numbers are the default, min, and max values of routingVelocity.
Test Results
The test domain is the Bow at Banff basin. The model includes 51 GRUs and runs for the year of 2008 (365 days). The model output is daily averageRoutedRunoff_mean.
Below is the model output comparison for one GRU (10 days).
- The black line is for the timeDlay method (old method).
- The other two lines are for the constVel method (newly added method).
- The red line uses flow velocity=100m/s, and the blue line uses flow velocity=0.1m/s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Initial capabilities to use a velocity parameter to define the scale of the Gamma distribution. Hongli will complete testing.