Conversation
…debug output if print flag is turned on.
Updates to summaSolve4homegrown: made checkConv a module procedure for external access
* remove_numJacHomegrown: fixing for compilation just spaces remove more globalPrint and print stateVars if needed remove commented prints, put some on flags cleaning globalPrintFlag removing flux prints remove unneeded globalPrintFlag remove stuff related to numerical Jacobian
Updates to summaSolve4homegrown for external access to getBrackets procedure
…cedure (to permit external access).
…ummaSolve4homegrown_updates
…ooks like floating point differences in test case 2 (1E-18, dropping to 1E-19 in 5ish timesteps)
…larSoilControl value - this affects simulations (particularly in case 01 and 02)
soilLiqFlx refactor
…DataWindowSteps is maximum number of steps with event detection for IDA per data window
* commit '03f98c3ac839cc3c9e218d0089f6f59ee1feb65b': (75 commits) removed another incorrectly addef ile added the correct changed files; removed the incorrect ones propagated Ashley's install instructions removed surfRun_IE removed surfRun_IE; updated comment removed surfRun_IE decision; updated comment removed surfRun_IE decision; updated comments removed imports removed update_gather_runoff_components, this also fixes a bug in scalarSoilControl value - this affects simulations (particularly in case 01 and 02) moved deriv initialization to init routine bugfix + code removal (tests still at 1E-19/1E-20) started revamp of infiltration routine - this change introduce what looks like floating point differences in test case 2 (1E-18, dropping to 1E-19 in 5ish timesteps) updated scalarSoilControl code (tests still same) removed scalarSatArea from _computation_homegrown (no longer needed, tests still same) removed duplicate frozen_area calc as well as unneeded inf_update (tests still same) removed zero_IE (tests still same) cleaned some comments and error message combined infiltrating_area and validate_inf_area into _homegrown (tests still the same) moved computation_frozen_area (tests still as before) removed variable Ac from routine (test still perfect or within 1E-20) ...
Continuing sundials merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
masterwith the SUNDIALS and related developments. High level changes: