Using the wrong format fails hard #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI I didn't run flake - will if needed |
Collaborator
|
Closing and re-opening to try to get GH action workflow to re-run. |
Collaborator
|
@heathhenley Thanks for the contribution. I'm so sorry for the delay. Could you also add case for this to the integration test as well? Thanks! |
Contributor
Author
|
Happy to, is some thing like (110637a) enough or would to want to include more examples? |
selimnairb
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brians!
I was using this to check our submission format (turns out it's "almost 3.0.0") 🤷♂️. Playing around with it, I noticed that if you run with the latest format against an old format file it fails hard with a key_error.
Maybe that's preferred because the format is wrong. If not, I added a failing test to reproduce with the existing test files you had in there and fixed so it fails nicely.