change dynamics minimum area and mass values and add Icepack parameters to remove residual ice#1067
Merged
apcraig merged 6 commits intoCICE-Consortium:mainfrom Nov 26, 2025
Merged
Conversation
…ation, add FSD title for diags
…efault behavior for itd min area, mass
Contributor
Author
|
I went through so many iterations trying to make a PR without conflicts, it would be a good idea to run this one through the full test suites before it's merged. |
18 tasks
Contributor
|
I have run though a fairly comprehensive test suite as well as compare this PR to the earlier one and everything looks perfect. I see no code differences from the earlier PR and the tests are doing what we expect. |
apcraig
approved these changes
Nov 24, 2025
Contributor
|
I will merge this in the next day or two unless I hear otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializes Icepack's minimum area and mass parameters to dynamics values, and sets the default dynamics parameters to small values. This PR replaces add Icepack minimum area and mass parameters #1055
@eclare108213 @DeniseWorthen
Extensive testing was done for the Icepack PR, Zap residual ice Icepack#543
See comments there and in add Icepack minimum area and mass parameters #1055
Addresses Residual ice #645. The required Icepack changes are in Zap residual ice Icepack#543.
Removes residual amounts of ice that are not otherwise handled by the numerics. The controlling parameters (
itd_area_minanditd_mass_min, implemented in Icepack) set minimum ice area and mass values below which all ice is removed following the thermodynamics and ridging calculations. For the B-grid, these parameters are currently set to the dynamics stability minima, which are being reduced to extremely small values based on testing in multiple modeling systems. If needed, users can revert these parameters to the original, larger values by adding them to ice_in. Setting them to 0 turns off the new zapping completely. These parameters are set to the larger, original values in the C-grid test scripts, pending further work.