Skip to content

change dynamics minimum area and mass values and add Icepack parameters to remove residual ice#1067

Merged
apcraig merged 6 commits intoCICE-Consortium:mainfrom
eclare108213:residual_dynmin7
Nov 26, 2025
Merged

change dynamics minimum area and mass values and add Icepack parameters to remove residual ice#1067
apcraig merged 6 commits intoCICE-Consortium:mainfrom
eclare108213:residual_dynmin7

Conversation

@eclare108213
Copy link
Contributor

  • Short (1 sentence) summary of your PR:
    Initializes Icepack's minimum area and mass parameters to dynamics values, and sets the default dynamics parameters to small values. This PR replaces add Icepack minimum area and mass parameters #1055
  • Developer(s):
    @eclare108213 @DeniseWorthen
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Extensive testing was done for the Icepack PR, Zap residual ice Icepack#543
    See comments there and in add Icepack minimum area and mass parameters #1055
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
    Addresses Residual ice #645. The required Icepack changes are in Zap residual ice Icepack#543.

Removes residual amounts of ice that are not otherwise handled by the numerics. The controlling parameters (itd_area_min and itd_mass_min, implemented in Icepack) set minimum ice area and mass values below which all ice is removed following the thermodynamics and ridging calculations. For the B-grid, these parameters are currently set to the dynamics stability minima, which are being reduced to extremely small values based on testing in multiple modeling systems. If needed, users can revert these parameters to the original, larger values by adding them to ice_in. Setting them to 0 turns off the new zapping completely. These parameters are set to the larger, original values in the C-grid test scripts, pending further work.

@eclare108213
Copy link
Contributor Author

I went through so many iterations trying to make a PR without conflicts, it would be a good idea to run this one through the full test suites before it's merged.

@apcraig
Copy link
Contributor

apcraig commented Nov 24, 2025

I have run though a fairly comprehensive test suite as well as compare this PR to the earlier one and everything looks perfect. I see no code differences from the earlier PR and the tests are doing what we expect.

@apcraig
Copy link
Contributor

apcraig commented Nov 24, 2025

I will merge this in the next day or two unless I hear otherwise.

@apcraig apcraig merged commit fa682b3 into CICE-Consortium:main Nov 26, 2025
2 checks passed
@eclare108213 eclare108213 deleted the residual_dynmin7 branch December 4, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants