Skip to content

Dev/wcoss#1083

Closed
rgrumbine wants to merge 12 commits intoCICE-Consortium:mainfrom
rgrumbine:dev/wcoss
Closed

Dev/wcoss#1083
rgrumbine wants to merge 12 commits intoCICE-Consortium:mainfrom
rgrumbine:dev/wcoss

Conversation

@rgrumbine
Copy link
Copy Markdown
Contributor

@rgrumbine rgrumbine commented Jan 13, 2026

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Wcoss2 execution
  • Developer(s):
    Robert Grumbine
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Quick Suite all passes
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
    Adding env and Macros, plus decision points to cice.batch and cice.launch for running on WCOSS2 (NWS Operational machine)

[ech edited to fix checkboxes]

Copy link
Copy Markdown
Contributor

@NickSzapiro-NOAA NickSzapiro-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working this out @rgrumbine . This is unused in UFS

@apcraig
Copy link
Copy Markdown
Contributor

apcraig commented Jan 14, 2026

Looks like there are two entries for wcoss in cice.batch.csh that are the same minus some comments, please remove one of those. There are some other "wcoss" porting files ("phase3_intel", "wcoss_dell_p3_intel"), could they be removed? Looks like the wcoss_dell_p3_intel was started but never completed and the phase3_intel might have been working at some point, is it still valid?

@rgrumbine rgrumbine closed this Mar 20, 2026
@rgrumbine rgrumbine deleted the dev/wcoss branch March 20, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants