Closed
Conversation
NickSzapiro-NOAA
approved these changes
Jan 13, 2026
Contributor
NickSzapiro-NOAA
left a comment
There was a problem hiding this comment.
Thanks for working this out @rgrumbine . This is unused in UFS
Contributor
|
Looks like there are two entries for wcoss in cice.batch.csh that are the same minus some comments, please remove one of those. There are some other "wcoss" porting files ("phase3_intel", "wcoss_dell_p3_intel"), could they be removed? Looks like the wcoss_dell_p3_intel was started but never completed and the phase3_intel might have been working at some point, is it still valid? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
Wcoss2 execution
Robert Grumbine
Quick Suite all passes
Adding env and Macros, plus decision points to cice.batch and cice.launch for running on WCOSS2 (NWS Operational machine)
[ech edited to fix checkboxes]