Skip to content

Fix some bugs with the last CMIP7 PR#1088

Merged
apcraig merged 3 commits intoCICE-Consortium:mainfrom
ESCOMP:cmip7plus
Jan 24, 2026
Merged

Fix some bugs with the last CMIP7 PR#1088
apcraig merged 3 commits intoCICE-Consortium:mainfrom
ESCOMP:cmip7plus

Conversation

@dabail10
Copy link
Copy Markdown
Contributor

@dabail10 dabail10 commented Jan 23, 2026

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Some bug fixes with the CESM cap and also the sitimefrac variable.
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#b7091b1b0d290fdc9e69d15a5b9b54f99e5b50ba
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
  • Bug fix for lwout in CESM driver
  • Also some FSD stuff for coupling
  • Fix define for sitimefrac
  • Add the CESM3 namelist changes Post modeling center configurations for Consortium testing and user reference #971
  • should address most of Errors updating EMC/CICE to top of main #1087

Copy link
Copy Markdown
Contributor

@apcraig apcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I will merge soon unless I hear any complaints.

@apcraig apcraig merged commit a214a72 into CICE-Consortium:main Jan 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants