Update Icepack to #daa41638c6cef, enforce minimum snow grain radius#1089
Merged
apcraig merged 1 commit intoCICE-Consortium:mainfrom Jan 28, 2026
Merged
Update Icepack to #daa41638c6cef, enforce minimum snow grain radius#1089apcraig merged 1 commit intoCICE-Consortium:mainfrom
apcraig merged 1 commit intoCICE-Consortium:mainfrom
Conversation
njeffery
approved these changes
Jan 28, 2026
Contributor
njeffery
left a comment
There was a problem hiding this comment.
Corrects a bug in snow grain radius. Tested in E3SMv3 ocean-ice and fully-coupled cases.
dabail10
approved these changes
Jan 28, 2026
eclare108213
approved these changes
Jan 28, 2026
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Update Icepack to #daa41638c6cef, enforce minimum snow grain radius
apcraig
Ran full test suites on derecho with intel and gnu plus quick suites with 6 compilers. All results are as expected. Both snow (except snw30percent) and bgc cases are NOT bit-for-bit as expected.
Update Icepack to #daa41638c6cef to include
Enforce minimum snow grain radius (#552)
If the snow grain radius is set to zero, possibly because of zapping small ice or if ice disappears mid-timestep, then updates of snow grain radius will produce NaNs. Snow grain radius is usually bounded between a min and max so this generally doesn't happen, but a recent coupled E3SM bgc run crashed with this error. While the error seems to be relatively rare, this bug fix changes answers when the snow grain radius is nonzero but still less than the minimum.