Skip to content

Update Icepack to #daa41638c6cef, enforce minimum snow grain radius#1089

Merged
apcraig merged 1 commit intoCICE-Consortium:mainfrom
apcraig:snowrad
Jan 28, 2026
Merged

Update Icepack to #daa41638c6cef, enforce minimum snow grain radius#1089
apcraig merged 1 commit intoCICE-Consortium:mainfrom
apcraig:snowrad

Conversation

@apcraig
Copy link
Copy Markdown
Contributor

@apcraig apcraig commented Jan 28, 2026

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Icepack to #daa41638c6cef, enforce minimum snow grain radius
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran full test suites on derecho with intel and gnu plus quick suites with 6 compilers. All results are as expected. Both snow (except snw30percent) and bgc cases are NOT bit-for-bit as expected.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial for snow and bgc configurations
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Update Icepack to #daa41638c6cef to include

Enforce minimum snow grain radius (#552)

If the snow grain radius is set to zero, possibly because of zapping small ice or if ice disappears mid-timestep, then updates of snow grain radius will produce NaNs. Snow grain radius is usually bounded between a min and max so this generally doesn't happen, but a recent coupled E3SM bgc run crashed with this error. While the error seems to be relatively rare, this bug fix changes answers when the snow grain radius is nonzero but still less than the minimum.

Copy link
Copy Markdown
Contributor

@njeffery njeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrects a bug in snow grain radius. Tested in E3SMv3 ocean-ice and fully-coupled cases.

@apcraig apcraig merged commit c734c12 into CICE-Consortium:main Jan 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants