Skip to content

Initialize worka for sifb history#1092

Merged
apcraig merged 2 commits intoCICE-Consortium:mainfrom
NickSzapiro-NOAA:sifb_init
Feb 16, 2026
Merged

Initialize worka for sifb history#1092
apcraig merged 2 commits intoCICE-Consortium:mainfrom
NickSzapiro-NOAA:sifb_init

Conversation

@NickSzapiro-NOAA
Copy link
Copy Markdown
Contributor

@NickSzapiro-NOAA NickSzapiro-NOAA commented Feb 16, 2026

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Minor bug fix to initialize worka=0 for sifb history
  • Developer(s):
    Nick Szapiro
  • Suggest PR reviewers from list in the column to the right.
    I don't have permissions to do this (?)
  • Please copy the PR test results link or provide a summary of testing completed below.
    ufs-weather-model regression testing
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit, for all variables except sifb history
    • different at roundoff level
    • more substantial bug fixes for sifb history
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
    Minor fix to initialize worka=0 for sifb history variable accumulation (like elsewhere in ice_history) so don't have uninitialized values being accumulated. This is needed to fix out-of-range history values for sifb (in UFS)

@NickSzapiro-NOAA
Copy link
Copy Markdown
Contributor Author

Some freeboards in ufs-weather-model regression tests were huge (like 10^3 to 10^6) and fixed with this

Copy link
Copy Markdown
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@apcraig apcraig self-requested a review February 16, 2026 21:11
@apcraig apcraig added the IO label Feb 16, 2026
@apcraig apcraig merged commit 7e810b6 into CICE-Consortium:main Feb 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants