Skip to content

Remove unused _init variables#539

Merged
apcraig merged 2 commits intoCICE-Consortium:mainfrom
eclare108213:iclean_init
Sep 3, 2025
Merged

Remove unused _init variables#539
apcraig merged 2 commits intoCICE-Consortium:mainfrom
eclare108213:iclean_init

Conversation

@eclare108213
Copy link
Contributor

@eclare108213 eclare108213 commented Aug 26, 2025

  • Short (1 sentence) summary of your PR:
    Clean up a few unused variables and update documentation
  • Developer(s):
    @eclare108213
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    All quick-suite tests pass
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Removing a few unused variables (aice_init, vice_init). Installed conda on a new laptop and discovered that the hardware platform is no longer x86_64, which slightly changes the miniconda porting instructions.

@eclare108213 eclare108213 requested a review from apcraig August 26, 2025 18:39
@eclare108213 eclare108213 changed the title emove unused _init variables Remove unused _init variables Aug 26, 2025
@eclare108213
Copy link
Contributor Author

If the intent of the code boxes in the docs is to allow a user to copy everything in the box and paste it in all at once, then my change will require its own box.

@apcraig
Copy link
Contributor

apcraig commented Aug 29, 2025

This all looks reasonable. Do the conda instructions work fine for ARM if you just download the correct version of miniconda? Or are there other changes needed?

@eclare108213
Copy link
Contributor Author

Unfortunately I followed the instructions from the download site rather than those in our docs, so I'm not 100% sure, but I believe they will work the same. I did this, which amounts to almost the same thing:

curl https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-arm64.sh -o ~/miniconda3/miniconda.sh
bash ~/miniconda3/miniconda.sh -b -u -p ~/miniconda3
rm ~/miniconda3/miniconda.sh
cd icepack_ech_20250826/
conda init bash
source $HOME/miniconda3/bin/activate
conda env create -f configuration/scripts/machines/environment.yml

The flags on the bash command are different.

@apcraig apcraig merged commit 3c2eeb5 into CICE-Consortium:main Sep 3, 2025
2 checks passed
@eclare108213 eclare108213 deleted the iclean_init branch December 4, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants