Remove unused _init variables#539
Merged
apcraig merged 2 commits intoCICE-Consortium:mainfrom Sep 3, 2025
Merged
Conversation
Contributor
Author
|
If the intent of the code boxes in the docs is to allow a user to copy everything in the box and paste it in all at once, then my change will require its own box. |
Contributor
|
This all looks reasonable. Do the conda instructions work fine for ARM if you just download the correct version of miniconda? Or are there other changes needed? |
Contributor
Author
|
Unfortunately I followed the instructions from the download site rather than those in our docs, so I'm not 100% sure, but I believe they will work the same. I did this, which amounts to almost the same thing: The flags on the bash command are different. |
dabail10
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up a few unused variables and update documentation
@eclare108213
All quick-suite tests pass
Removing a few unused variables (aice_init, vice_init). Installed conda on a new laptop and discovered that the hardware platform is no longer x86_64, which slightly changes the miniconda porting instructions.