clarify uv and par comments and doc#549
Merged
apcraig merged 3 commits intoCICE-Consortium:mainfrom Jan 22, 2026
Merged
Conversation
Contributor
Author
|
@zhaobin74 please take a look at these changes to make sure they are correct. Thanks! |
zhaobin74
reviewed
Jan 21, 2026
zhaobin74
reviewed
Jan 21, 2026
Contributor
Author
|
As noted in #548, this issue is a bit complicated due to the evolution of the shortwave parameterization over many years. For this PR, in addition to removing the word 'visible' I changed the uv comments to state '< 400 nm' and added some (hopefully) clarifying text to the docs. Ready for review. |
zhaobin74
approved these changes
Jan 22, 2026
Contributor
zhaobin74
left a comment
There was a problem hiding this comment.
This looks clear to me. Thanks, @eclare108213.
apcraig
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify uv and par radiation descriptions in code comments and documentation.
@eclare108213
See updated documentation. All code changes are in comments.
The word 'visible' is confusing in the comments for ultraviolet radiation bands and not needed for PAR. It was removed for the uv and PAR variables but left as-is for older code, which used the term in a general sense for wavelengths < 700 nm. Changed the uv comments to state '< 400 nm' and added some text to the docs.
Closes #548