Skip to content

San Jewell Submission #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

San Jewell Submission #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,14 @@ Extra credit if you can find all FIVE bugs.
- In the README, create a link to your shader toy solution with the bugs corrected
- In the README, describe each bug you found and include a sentence about HOW you found it.
- Make sure all three of your shadertoys are set to UNLISTED or PUBLIC (so we can see them!)

# Actual Submission
- Only San Jewell worked on this
- link is here: https://www.shadertoy.com/view/mdS3Rt
- I found 4/5 bugs (I think, though it looks pretty good), all of them are marked in the shadertoy as well
- line 102, fixed syntax error because it was obvious and the compiler told me
- line 105, changed uv to uv2. I found this because it seemed very obvious that the entire rendering was shifted in screen space, so I looked first at the uv2 calculation and it seemed right, and then I saw it was not used.
- line 11, changed the resolution x to y. This one was a bit of luck, I did notice that the screen looked a little stretched but I wasn't actually sure it was a bug. But then after looking over everything for a few minutes I managed to see this in the third pass. Very sneaky
- line 75, the main issue with pretty much everything not working. I didn't immediately have on my mind how the reflection algorithm worked so I spent a lot of time just trying to add parenthesis around operations and scan for any more variable mis usages. This didn't work so I started going through line by line and actually trying to understand what was being done at each step. Eventually I looked up a similar algorithm description and I saw the reflection used in it and I realized that there the wrong variable was used there.

I think it looks pretty good, so either I accidentally fixed another bug while messing around with a bunch of the code, or I'm just missing what the final issue is.