Skip to content

Debugging Lab Logan #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Debugging Lab Logan #7

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
add26e1
Update README.md
logancho Nov 9, 2022
95ade41
Update README.md
logancho Nov 9, 2022
a4bafc4
Update README.md
logancho Nov 9, 2022
541a304
Update README.md
logancho Nov 9, 2022
8081153
Update README.md
logancho Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,29 @@
Submission:

https://www.shadertoy.com/view/msBGzt

Collaborators: None

Bug number 1:

Spheres look deformed. Cause: aspect ratio was incorrect in the projection part of the raycast function!

Bug number 2:

Spheres are off center, rotation is weird. Cause: Incorrect uv coordinates sent! We calculated NDC uv2, but never actually inputted it into the raycast function. This would explain the offset.

Bug number 3:

Specular reflection missing. I knew that the bug would have to be inside sdf3d. It turns out we were reflecting eye instead of dir! Replacing eye with dir fixed this bug.

Bug number 0:

Compiler error- fixed by adding type declaration vec2 to uv2!

Bug number 5:

Fixed floor artifacts by increasing number of iterations of march! This issue happens to rays that get very close but dont actually intersect objects in sphere tracing, since many iterations are used up by very small increments forward, resulting in no intersection if the number of iterations isnt high enough.

# lab06-debugging

# Setup
Expand Down