Skip to content

Rhuta Joshi and Joanna Fisch #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rhuta Joshi and Joanna Fisch #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c4da21
Update README.md
rcj9719 Nov 9, 2022
f79cb35
Update README.md
rcj9719 Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,22 @@ It don't do that. Correct THREE of the FIVE bugs that are messing up the output.

Extra credit if you can find all FIVE bugs.

# Solution

### Team members: Joanna Fisch, Rhuta Joshi

### Bugs:

|Line No.|Artifact/Issue that helped in identification|Correction|
|---|---|---|
|99|Compile time error, vec not found| Replaced vec with vec2|
|102|Made the image appear flat or with incorrect resolution|Passed remapped uv2 instead of uv to rayCast function|
|11|Everything appeared stretched along x axis|`iResolution.x/iResolution.x` replaced with `iResolution.x/iResolution.y`|
|76|Reflection not working, spheres looked flat shaded|Was reflecting eye about normal instead of dir about normal|
|18|Disappearing floor plane around edges of spheres|Very small value of max ray steps, updated from 64 to 256|

[Corrected shadertoy link](https://www.shadertoy.com/view/msBGRd)

# Submission
- Create a pull request to this repository
- In the README, include the names of both your team members
Expand Down