Skip to content

Lab 2: Sherry Li #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Lab 2: Sherry Li #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c24f72
Update README.md
sherryli02 Sep 20, 2023
a1c784f
Update README.md
sherryli02 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# lab06-debugging

Link to solution with bugs corrected: https://www.shadertoy.com/view/Ds3czj

1. Line 97: Changed vec to vec2; console was displaying a syntax error
2. Line 100: Changed uv to uv2. I noticed that uv2 wasn't being used
3. Line 11: Changed the second iResolution.x to iResolution.y. Spotted since it was strange to multiply and divide by the same variable
4. Line 75: Changed eye to dir in the reflect inputs. Knew there was an issue with the specular since the reflections weren't showing, and thought it made more sense to pass in dir than eye
5. Line 18: Made i loop for a larger number of iterations. Saw that the back "clipping plane" wasn't as far as the desired output, so thought to make it march for more steps

# Setup

Create a [Shadertoy account](https://www.shadertoy.com/). Either fork this shadertoy, or create a new shadertoy and copy the code from the [Debugging Puzzle](https://www.shadertoy.com/view/flGfRc).
Expand Down