[WNMGDS-3315] Fixed aria-invalid
property previously assigned to Dropdown Button
#3516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
aria-invalid
value to any kind of element to a specific list of elements based on role (source).aria-invalid
role to the Dropdown Button, which is no longer a valid element of which to apply that attribute.aria-invalid
attribute to the element with the listbox role instead, which is an allowed role for that attribute.How to test
npm run storybook
and go to the Dropdown<button>
element no longer hasaria-invalid="false"
Checklist
[WNMGDS-####] Title
or [NO-TICKET] if this is unticketed work.Type
(only one) label for this PR, if it is a breaking change, label should only beType: Breaking
Impacts
, multiple can be selected.If this is a change to code:
npm run test:unit
andnpm run test:browser:all
were each successfulnpm run test:unit:update
) and browser-test snapshots (npm run test:browser:all:update
)