Skip to content

[CMSDS-3343] Upgrade to Storybook v9 - #4162

Draft
derek-cmsds wants to merge 7 commits into
mainfrom
dhouck/cmsds-3343/storybook-v9
Draft

[CMSDS-3343] Upgrade to Storybook v9#4162
derek-cmsds wants to merge 7 commits into
mainfrom
dhouck/cmsds-3343/storybook-v9

Conversation

@derek-cmsds

@derek-cmsds derek-cmsds commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • There's a large number of files changed in this PR. Most of it is updating imports.
  • We use Storybook for documentation & testing. We're on version 8.6. This PR upgrades us to 9.1.20 using the migration guide and the automatic upgrade command.
  • CMSDS-3343

How to test

  1. npm run freshen
  2. Start Storybook
  3. Verify Storybook loads successfully.
  4. Verify Stories within Storybook load successfully.
  5. Verify all tests pass successfully.

Checklist

  • Prefixed the PR title with the Jira ticket number as [CMSDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

If this is a change to code:

  • Created or updated unit tests to cover any new or modified code
  • Verified that running both npm run test:unit and npm run test:browser:all were each successful
  • If necessary, updated unit-test snapshots (npm run test:unit:update) and browser-test snapshots (npm run test:browser:all:update)

@derek-cmsds derek-cmsds added Type: Internal This item relates to internal tooling/maintenance Impacts: Documentation Indicates that this item relates to documentation labels Jul 24, 2026
@derek-cmsds derek-cmsds added this to the 19.0.0 milestone Jul 24, 2026

const storySkipList = [
'components-autocomplete--async-items', // Redundant
'components-choicelist--choice-children', // Focus bug in Storybook v9

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The a11y tests for this Story was giving me a "Maximum call stack size exceeded" error. It appears to be this bug: storybookjs/storybook#32603

Unfortunately, the Storybook team appears to have fixed the bug in v10 and not in v9, so we need to disable this test until we can get Storybook updated to v10. I've created https://jira.cms.gov/browse/CMSDS-4241 to re-enable these tests once we are on Storybook v10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Impacts: Documentation Indicates that this item relates to documentation Type: Internal This item relates to internal tooling/maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant