[CMSDS-3343] Upgrade to Storybook v9 - #4162
Draft
derek-cmsds wants to merge 7 commits into
Draft
Conversation
derek-cmsds
commented
Jul 27, 2026
|
|
||
| const storySkipList = [ | ||
| 'components-autocomplete--async-items', // Redundant | ||
| 'components-choicelist--choice-children', // Focus bug in Storybook v9 |
Collaborator
Author
There was a problem hiding this comment.
The a11y tests for this Story was giving me a "Maximum call stack size exceeded" error. It appears to be this bug: storybookjs/storybook#32603
Unfortunately, the Storybook team appears to have fixed the bug in v10 and not in v9, so we need to disable this test until we can get Storybook updated to v10. I've created https://jira.cms.gov/browse/CMSDS-4241 to re-enable these tests once we are on Storybook v10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How to test
npm run freshenChecklist
[CMSDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to code:
npm run test:unitandnpm run test:browser:allwere each successfulnpm run test:unit:update) and browser-test snapshots (npm run test:browser:all:update)