Skip to content

CSoC Week 3 Submission #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

BabyElias
Copy link

[x] Auth Middleware
[x] Login Function
[x] Add task
[x] Get tasks
[x] Update Task
[x] Delete Task
[x] UI Improvement

Repo Link : https://github.com/BabyElias/csoc-week3-vue
Deployment Link : https://csoc-week3-vue-nn.vercel.app/login

Copy link
Collaborator

@tiger-yash tiger-yash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good attempt!

Shortcomings:

  • No significant UI improvement.
  • dist files should not be committed to the repo

@BabyElias
Copy link
Author

About the dist files, deployment failed multiple times on both Heroku and Vercel with the reason that Dist files could not be found. Any other way I could have deployed without adding it would be really appreciated !

@tiger-yash
Copy link
Collaborator

@BabyElias
Dist files are never included with the code and are only generated during production. Including them with the code, is not the solution and considered bad practice.

Try to look for best solutions, you have google at your disposal.
And as far as deployment on vercel is concerned, override the Build Command to npm run generate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants