feat: support pwa via @vite-pwa/nuxt - #304
Conversation
Dokploy Preview Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe Nuxt application adds ChangesPWA integration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ca68df9ad
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| pwa: { | ||
| registerType: 'autoUpdate', |
There was a problem hiding this comment.
Preserve the slash in the PWA base path
With this PWA block relying on @vite-pwa/nuxt defaults, the module takes the current app.baseURL (/2026) as its base/scope and vite-plugin-pwa concatenates that with manifest.webmanifest and sw.js. On the GitHub Pages deployment this emits links like /2026manifest.webmanifest and registers /2026sw.js instead of /2026/manifest.webmanifest and /2026/sw.js, so the new manifest/service worker 404 and the site is not installable. Set the PWA base/buildBase/scope (or the app base URL) to the slash-terminated /2026/.
Useful? React with 👍 / 👎.
Summary by CodeRabbit