Skip to content

feat: support pwa via @vite-pwa/nuxt - #304

Open
Spyup wants to merge 1 commit into
COSCUP:mainfrom
Spyup:feature/pwa
Open

feat: support pwa via @vite-pwa/nuxt#304
Spyup wants to merge 1 commit into
COSCUP:mainfrom
Spyup:feature/pwa

Conversation

@Spyup

@Spyup Spyup commented Aug 2, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • New Features
    • Added Progressive Web App support, including an installable app manifest and application icons.
    • Added theme-color metadata for improved browser and mobile device integration.
    • Enabled automatic service worker updates and offline asset handling.

@rileychh-dokploy-coscup

rileychh-dokploy-coscup Bot commented Aug 2, 2026

Copy link
Copy Markdown

Dokploy Preview Deployment

Name Status Preview Updated (UTC)
Nuxt ❌ Failed Preview URL 2026-08-03T08:57:41.784Z

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 52abbcb7-90ab-4d89-a67e-0ab7541217fb

📥 Commits

Reviewing files that changed from the base of the PR and between 7475ba8 and 2ca68df.

⛔ Files ignored due to path filters (5)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • public/pwa-192.png is excluded by !**/*.png
  • public/pwa-512-markable.png is excluded by !**/*.png
  • public/pwa-512.png is excluded by !**/*.png
  • public/pwa-apple-touch.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • app/app.vue
  • nuxt.config.ts
  • package.json

📝 Walkthrough

Walkthrough

The Nuxt application adds @vite-pwa/nuxt, configures PWA metadata, icons, automatic updates, and Workbox precaching, then renders the generated manifest in the root template.

Changes

PWA integration

Layer / File(s) Summary
PWA module and configuration
package.json, nuxt.config.ts
Adds the PWA module, shared theme color, Apple touch icon, theme-color metadata, localized manifest settings, application icons, automatic update registration, and Workbox precaching patterns.
Global manifest rendering
app/app.vue
Adds VitePwaManifest to the root application template.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: rileychh, mirumodapon

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding PWA support through @vite-pwa/nuxt.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ca68df9ad

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread nuxt.config.ts
Comment on lines +192 to +193
pwa: {
registerType: 'autoUpdate',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the slash in the PWA base path

With this PWA block relying on @vite-pwa/nuxt defaults, the module takes the current app.baseURL (/2026) as its base/scope and vite-plugin-pwa concatenates that with manifest.webmanifest and sw.js. On the GitHub Pages deployment this emits links like /2026manifest.webmanifest and registers /2026sw.js instead of /2026/manifest.webmanifest and /2026/sw.js, so the new manifest/service worker 404 and the site is not installable. Set the PWA base/buildBase/scope (or the app base URL) to the slash-terminated /2026/.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant