renamed compute_performance_features to make_performance_features to …

…make it uniform with make_note_features.
CPJKU · Jun 9, 2023 · d56ef15 · d56ef15
1 parent 7f7d8b7
commit d56ef15
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 16 deletions.
diff --git a/partitura/musicanalysis/__init__.py b/partitura/musicanalysis/__init__.py
@@ -21,7 +21,7 @@
     make_rest_features,
 )
 from .performance_codec import encode_performance, decode_performance
-from .performance_features import compute_performance_features
+from .performance_features import make_performance_features
 from .note_array_to_score import note_array_to_score
 
 
@@ -38,6 +38,6 @@
     "decode_performance",
     "compute_note_array",
     "full_note_array",
-    "compute_performance_features",
+    "make_performance_features",
     "note_array_to_score"
 ]
diff --git a/partitura/musicanalysis/performance_features.py b/partitura/musicanalysis/performance_features.py
@@ -22,7 +22,7 @@
 
 
 __all__ = [
-    "compute_performance_features",
+    "make_performance_features",
 ]
 
 # ordinal 
@@ -32,12 +32,12 @@
 class InvalidPerformanceFeatureException(Exception):
     pass
 
-def compute_performance_features(score: ScoreLike, 
-                                performance: PerformanceLike,
-                                alignment: list,
-                                feature_functions: Union[List, str],
-                                add_idx: bool = True
-):
+def make_performance_features(score: ScoreLike,
+                              performance: PerformanceLike,
+                              alignment: list,
+                              feature_functions: Union[List, str],
+                              add_idx: bool = True
+                              ):
     """
     Compute the performance features. This function is defined in the same 
     style of note_features.make_note_features
@@ -164,9 +164,9 @@ def list_performance_feats_functions():
     """Return a list of all feature function names defined in this module.
 
     The feature function names listed here can be specified by name in
-    the `compute_performance_features` function. For example:
+    the `make_performance_features` function. For example:
 
-    >>> feature, names = compute_performance_features(score,
+    >>> feature, names = make_performance_features(score,
                                                     performance,
                                                     alignment,
                                                     ['asynchrony_feature'])

diff --git a/tests/test_performance_features.py b/tests/test_performance_features.py
@@ -7,7 +7,7 @@
 import numpy as np
 from partitura import load_match
 from tests import MATCH_EXPRESSIVE_FEATURES_TESTFILES
-from partitura.musicanalysis.performance_features import compute_performance_features
+from partitura.musicanalysis.performance_features import make_performance_features
 import os
 
 
@@ -34,9 +34,9 @@ def test_performance_features(self):
              ('beat_period', '<f4')])
         fn = MATCH_EXPRESSIVE_FEATURES_TESTFILES[0]
         perf, alignment, score = load_match(filename=fn, create_score=True)
-        features = compute_performance_features(score, 
-                                                perf,
-                                                alignment,
-                                                feature_functions = "all")
+        features = make_performance_features(score,
+                                             perf,
+                                             alignment,
+                                             feature_functions = "all")
 
         self.assertTrue(np.all(True_array[fields] == features[fields][:3]), f"The expression features don't match the original.")