Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track all MIDI messages for PerformedPart objects #343

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

CarlosCancino-Chacon
Copy link
Member

This pull request allows PerformedPart objects to track all MIDI message types. In particular it allows for tracking the following information

  • key signature
  • time signature
  • Meta MIDI messages

While this information is not necessarily reliable in performed MIDI files, it might be sometimes useful, in particular for generated music/performances.

@CarlosCancino-Chacon CarlosCancino-Chacon self-assigned this Jan 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (8ee8ba9) 85.19% compared to head (cfe0917) 85.18%.
Report is 2 commits behind head on develop.

Files Patch % Lines
partitura/io/exportmidi.py 28.57% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #343      +/-   ##
===========================================
- Coverage    85.19%   85.18%   -0.02%     
===========================================
  Files           81       81              
  Lines        13925    13949      +24     
===========================================
+ Hits         11863    11882      +19     
- Misses        2062     2067       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manoskary manoskary self-requested a review January 28, 2024 15:18
Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds Meta Messages about time tick, Key signatures and Time Signature in Midi performances for import and export. Its overall and nice and simple addition for completeness. It adds some typing and minor documentation

@manoskary manoskary merged commit 5ce6540 into develop Feb 1, 2024
3 checks passed
@huispaty huispaty deleted the load_perfmidi_update branch February 13, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants