Master #1
Open
Master #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ehat'/'phpspec'/'atoum'/'kahlan'/'peridot'/'phpunit', on Heroku CI
Heroku CI improvements: zend.assertions=1 and bin/test
We do not want New Relic and others to start and instrument during simple checks and processing and Composer invocations on boot. The previous approach with php -n prevents all PHP INIs from getting loaded, which means setups where even basics like PCRE or JSON are shared extensions and are loaded via a php.ini config directory would not work. This change instead appends a directory to PHP_INI_SCAN_DIR, and that directory contains an INI file with directives that prevents the startup of common APM extensions. Fixes #345, #348, #349
- changes the order of preference so global composer is preferred over project-local composer.phar (to prevent problems with old local versions etc e.g. on Heroku)
- uses 'command -v' instead of 'which', for POSIX compliance
- adds a check if composer (or .phar) is even there ('command -v' returns 0 if just any given program exists, not only if all exist like 'which')
- some quoting, just in case of spaces in people's directory names
…g bin/compile as well
They still have an old version, which is buggy with 'composer require --ignore-platform-reqs php:…', now we can drop that workaround
Not just for installation, but also for the new "suppress APM extension startup" behavior both at build and at runtime.
Refactor APM startup prevention
…pt for service related stuff
so that we do not get an update of libssl to 1.1.1, since the stack is still on 1.1.0
The library is used by PHP's `ext-imap`. SNI is required with TLSv1.3, and OpenSSL 1.1.1 supports TLSv1.3, so connections with that OpenSSL version may negotiate it. Some IMAP servers, like GMail, reject the connection (by returning an invalid self-signed certificate) if no "HostName" is sent.
Binaries update: PHP, extensions, Composer, and OpenSSL 1.1.1 forward compatibility
v159 release (changelog date only)
Update Gemfile deps, including Hatchet to v6
…res due to Symfony Console output issues with PHP 7.4
…n Heroku CI occasionally fails on PHP 7.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.