Skip to content

chore: asset.product typing fix - #127

Merged
sbrunato merged 1 commit into
developfrom
asset_product_typing
Aug 3, 2026
Merged

chore: asset.product typing fix#127
sbrunato merged 1 commit into
developfrom
asset_product_typing

Conversation

@sbrunato

@sbrunato sbrunato commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Fixes typing issues raised by mypy:

eodag_cube/api/product/_assets.py:73: error: "EOProduct" has no attribute "get_file_obj" [attr-defined]
eodag_cube/api/product/_assets.py:80: error: "EOProduct" has no attribute "rio_env" [attr-defined]

The cast tells mypy that in this package it is the eodag-cube EOProduct subclass, which does define get_file_obj and rio_env.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Benchmark comparison

Compared baseline: origin/develop
Compared candidate: 5ee2ccf


--------------------------------- benchmark: 5 tests, 2 sources ---------------------------------
Name (time in us)                                     baseline Median  candidate Median   ΔMedian
-------------------------------------------------------------------------------------------------
test_benchmark_eoproduct_instantiation                        21.0615           20.6460     -2.0%
test_benchmark_eoproduct_assets_population                    41.9030           42.8750     +2.3%
test_benchmark_to_xarray_local                            10,041.8620       10,143.5990     +1.0%
test_benchmark_import_eodag_cube_subprocess               12,167.1700       12,267.2490     +0.8%
test_benchmark_import_eodag_public_api_subprocess        487,038.9150      480,962.9985     -1.2%
-------------------------------------------------------------------------------------------------

Legend:
  Cyan: reference source for comparison. Green: improvement, Red: regression.
  Δ: percentage change from reference source.

@sbrunato
sbrunato merged commit 7f03f8a into develop Aug 3, 2026
7 checks passed
@sbrunato
sbrunato deleted the asset_product_typing branch August 3, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant