Merge final branch into main #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the question card truncate descriptions Added env.sample to app folder
Follow dockerfile for backend Add the redis/rabbitmq to compose as well
Matching service still seems unable to talk to redis
prevent users from matching with themselves
If they prove to be necessary, feel free to revert this commit.
This allows data to be filled in upon reconnection However, this requires removal of the dmp. TODO: Check if getting rid of dmp worsens performance
Previously, the comms fix depended on the connected user handshaking on the endCall message, which gives a tiny window where another user could potentially reconnect and send out the joinRoom message before cleanup of the previous call is finished. This change places the room leaving algo before the endCall message within the same hook as the disconnecting message, which should help mitigate this latency window issue by preventing messages from propagating to the frontend while its still performing its cleanup.
Add a simple status message indicating no call started
2 is too short and could be due to latency
Now, it does a paranoid check against the room ID that initiated the room closure to prevent a close-room from affecting the 2nd user if they are in a different room already.
Fix navbar logout, middleware, room closure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on collab-post-ms6-risky - please switch the branch appropriately based on what final branch we are using!