Kp 10636 entitlement management #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two features got unfortunately entagled in the same commit. But basically this will 1) Give entitlement headers to get_user_scope() from the db for getting the corpus list, the logic and data will be there 2) In debug mode, log headers and JWTs verbosely, and otherwise timestamp and unify our current logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite a big PR, accomplishing three closely related things:
Add support in the DB and auth code for entitlements. They live in their own table, and both they and users can be "grantees" referenced by the GRANTS table. In practice, Mink corpora will have grants referencing users, and KP corpora will have grants referencing entitlements.
Add admin endpoints for editing the database. Also nerfed the Mink endpoints so that Mink will only be able to affect Mink corpora, not (accidentally) production KP corpora. Also add a bunch of tests.
Add admin tool for adding KP corpora to the database. It accepts the TSV format emitted by the legacy "korp-authdb.py lbr_map" See tools/README.md.