Conversation
…bBasins, :ChannelProfile
…r to support data from CLRH. When parsing HRUs, return dict instead of an instance, so users can subclass HRUs
…em in the extractor test.
lou-a
approved these changes
May 2, 2025
Collaborator
lou-a
left a comment
lou-a
left a comment
There was a problem hiding this comment.
This worked for me for running our first SPS-Raven test.
…breaks the cli test suite
Member
|
@huard Merge when ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
parsemethods toLineCommand,SubBasins,HRUs,Reservoir,SubBasinGroup,ChannelProfile.GridWeightExtractorto support datasets from the Canadian River and Lake Hydrofabric. Allows setting therouting_id_fieldto__INDEX__in order to match HRU IDs.Rechargeprocess.Does this PR introduce a breaking change?
No.