Migrate from xclim.sdba to xsdba#511
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
huard
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
xclimto the latest version and introducesxsdbaDoes this PR introduce a breaking change?
Yes,
xclimno longer comes withSDBAsupport by default. While examples allow forxclim.sdbato be used, importing directly fromxsdbais the suggested API.Other information:
https://xsdba.readthedocs.io/en/latest/index.html
GDAL v3.11+ (available on macOS) includes major changes to the slope and hill shade algorithms. Default behaviour is changed. We may need to rewrite these to rely on Python-written algorithms if we want to ensure that the values remain similar.