Skip to content

Migrate from xclim.sdba to xsdba#511

Merged
Zeitsperre merged 8 commits into
masterfrom
xsdba-support
Jun 3, 2025
Merged

Migrate from xclim.sdba to xsdba#511
Zeitsperre merged 8 commits into
masterfrom
xsdba-support

Conversation

@Zeitsperre
Copy link
Copy Markdown
Member

@Zeitsperre Zeitsperre commented Jun 2, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updates xclim to the latest version and introduces xsdba
  • Marks two tests that rely on the now-modified GDAL CLI.

Does this PR introduce a breaking change?

Yes, xclim no longer comes with SDBA support by default. While examples allow for xclim.sdba to be used, importing directly from xsdba is the suggested API.

Other information:

https://xsdba.readthedocs.io/en/latest/index.html

GDAL v3.11+ (available on macOS) includes major changes to the slope and hill shade algorithms. Default behaviour is changed. We may need to rewrite these to rely on Python-written algorithms if we want to ensure that the values remain similar.

@Zeitsperre Zeitsperre requested review from huard and lou-a June 2, 2025 19:30
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Zeitsperre Zeitsperre self-assigned this Jun 2, 2025
@github-actions github-actions Bot added the docs label Jun 2, 2025
@github-actions github-actions Bot added the CI label Jun 2, 2025
@Zeitsperre Zeitsperre merged commit dcb7465 into master Jun 3, 2025
18 checks passed
@Zeitsperre Zeitsperre deleted the xsdba-support branch June 3, 2025 14:02
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 82.363% (+0.09%) from 82.274%
when pulling 9d267c8 on xsdba-support
into 4652e41 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants