Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feb 8 #24

Merged
merged 13 commits into from
Feb 14, 2025
Merged

Feb 8 #24

merged 13 commits into from
Feb 14, 2025

Conversation

Elan456
Copy link
Contributor

@Elan456 Elan456 commented Feb 9, 2025

Description

Summary of Changes

  • Adjust the launch detector to be more time interval lenient
  • Adjust data dump to page-by-page, requiring an 'n' character to be sent to continue
  • Add options to the data dump to send all the pages, skipping empty ones rather than stopping on them
  • Fix data dump, skipping every-other-page

Motivation

  • Greatly improves the reliability of the data dump by requiring input every 255 bytes.
  • Allows the user to dump all the data on the flash chip regardless of where the most recent launch stopped
  • Dumps all the data rather than half of it
  • It makes the launch detector less picky and more likely to operate even if the data updates become too slow or fast.

Testing

Check all that apply:

  • I have added or modified tests to cover these changes.
  • I have manually tested the changes on the target device(s) or environment(s).
  • Existing tests were reviewed to ensure they still work as expected.
  • If tests were not added or modified, explain why:

    (Provide reasoning here)


Building

  • This change successfully builds in at least one of the following environments:
    • Native repo
    • Target device(s) (e.g., MARTHA)
  • If the build fails in any environment, explain why:

    (Provide reasoning here)


Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code where necessary for clarity.
  • I have made corresponding updates to documentation (if applicable).

@Elan456 Elan456 requested a review from mvari1 February 9, 2025 16:37
@Elan456 Elan456 merged commit 5e992e4 into main Feb 14, 2025
@Elan456 Elan456 deleted the feb-8 branch February 14, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants