Skip to content

add macos-15-arm64 target #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add macos-15-arm64 target #53

wants to merge 1 commit into from

Conversation

dennyabraham
Copy link

No description provided.

bernhard-42
bernhard-42 reviewed May 4, 2025
View reviewed changes
Copy link
Collaborator

@bernhard-42 bernhard-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to build all wheels and pass all tests?
Typically one can't just change the os matrix. The compilation steps are extremely fragile and depend on the os version, installed libs (per os version), ...

@dennyabraham
Copy link
Author

my hope was that it would be as straightforward as opening a pr and watching the build. i'll see if i can build locally

@bernhard-42
Copy link
Collaborator

A little caveat, the full build takes hours :-)
And the build system caches steps in order to not start from scratch when something goes wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernhard-42 bernhard-42 bernhard-42 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennyabraham @bernhard-42