feat: Implement onboarding screen UI #70
Merged
Merged
Conversation
# Conflicts: # composeApp/src/commonMain/composeResources/values-ar/strings.xml # composeApp/src/commonMain/composeResources/values/strings.xml
MostafaMohamed2002
requested review from
Al-Qassim,
gehadepada and
iZyadNasser
and removed request for
Al-Qassim
Al-Qassim
reviewed
Aug 4, 2025
Comment on lines
+40
to
+39
| navigateToRegister = { navController.navigate(RegisterRoute) }, | ||
| navController = navController |
Contributor
There was a problem hiding this comment.
don't pass the nav controller, pass only the functions
navigateToLogin = { navController.navigate(LoginRoute) },
navigateToRegister = { navController.navigate(RegisterRoute) },
this is why when you click login in the video, you went to the home screen instead of the login screen
Member
Author
There was a problem hiding this comment.
okay i have updated it
Al-Qassim
reviewed
Aug 4, 2025
Comment on lines
+12
to
+18
| class OnBoardingViewModel: ViewModel() , OnboardingScreenListener { | ||
| private val _state = MutableStateFlow(OnboardingScreenState()) | ||
| val state = _state.asStateFlow() | ||
|
|
||
| private val _effect = MutableSharedFlow<OnboardingScreenEffect>() | ||
| val effect = _effect.asSharedFlow() | ||
|
|
Member
Author
There was a problem hiding this comment.
used the base view model
MostafaMohamed2002
force-pushed
the
feature/on-boarding
branch
from
de4f0fe to
b1b2f48
Compare
Al-Qassim
approved these changes
Aug 4, 2025
YoussefmSaber
approved these changes
Aug 4, 2025
Contributor
There was a problem hiding this comment.
replace this with svg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the new onboarding screen, which is the first screen the user sees when opening the app. It allows the user to select their preferred language and navigate to the login or sign-up screen.
Changes included:
OnBoardingViewModelto handle the business logic of the screen.OnboardingScreenState,OnboardingScreenListener, andOnboardingScreenEffectto manage the state and events of the screen.NoRippleClickutility for click effects.Closes #34
Screen_recording_20250804_185939.mp4