-
Notifications
You must be signed in to change notification settings - Fork 5
MAINT: post JB2 transition cleanup #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, LGTM other than the build fail.
Not sure where that's coming from. What do thebe and binder interactivity provide? |
|
somehow the node installing step is failing, I suggest waiting a bit and then restart CI binder+thebe will add in page execution, more about it here: https://mystmd.org/guide/in-page-execution |
|
SO, imo, this should now go in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interactivity looks cool. I'm a bit concerned about pushing experimental features into production at IRSA without some prior discussion. It affects the user experience. I'll leave this one to your discretion.
|
I would say let's try it, the functionality is not broken just not as smooth as it apparently was with JB1 (but we never used it there). |
cb4ef76 to
74493d6
Compare


Cleaning up old configs and making files named consistently between the repos.
Also, thebe and binder interactivity is opted in now.