Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Oct 24, 2025

Cleaning up old configs and making files named consistently between the repos.

Also, thebe and binder interactivity is opted in now.

@bsipocz bsipocz added maintainance html rendering / skip testing Rendering related issues/PRs. Skips tests in PRs. labels Oct 24, 2025
@troyraen
Copy link
Contributor

Thanks, LGTM other than the build fail.

/bin/bash: line 1: npm: command not found

Not sure where that's coming from.

What do thebe and binder interactivity provide?

@bsipocz
Copy link
Member Author

bsipocz commented Oct 24, 2025

somehow the node installing step is failing, I suggest waiting a bit and then restart CI

binder+thebe will add in page execution, more about it here: https://mystmd.org/guide/in-page-execution
(it's kind of experimental, but worked when I built it locally. I would see it as an alternative of the rocket launch options on the old, JB1 site)

@bsipocz
Copy link
Member Author

bsipocz commented Oct 24, 2025

Failures are unrelated and the preview is good enough as is to check out what this PR does, e.g. :

https://circle.scientific-python.dev/output/job/4beaa9f5-2bf4-40d1-a4cb-c78da2839b90/artifacts/0/_build/html/siav2-seip

(it's mostly the pop-out into a jupyterhub, but one can also restart the execution of the cells, etc with the buttons (there are some known issues with them, but it maybe useful to enable these just to collect feedback for upstream, too):
Screenshot 2025-10-24 at 13 25 30
Screenshot 2025-10-24 at 13 31 36

@bsipocz
Copy link
Member Author

bsipocz commented Oct 24, 2025

SO, imo, this should now go in.

Copy link
Contributor

@troyraen troyraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interactivity looks cool. I'm a bit concerned about pushing experimental features into production at IRSA without some prior discussion. It affects the user experience. I'll leave this one to your discretion.

@bsipocz
Copy link
Member Author

bsipocz commented Oct 25, 2025

I would say let's try it, the functionality is not broken just not as smooth as it apparently was with JB1 (but we never used it there).
Being able to launch the notebooks out to binder is actually quite nice even if the on page interactivity is a bit non-intuitive.

@bsipocz bsipocz force-pushed the MAINT_post_jb2_cleanup branch from cb4ef76 to 74493d6 Compare October 25, 2025 06:38
@bsipocz bsipocz merged commit 0278982 into Caltech-IPAC:main Oct 25, 2025
2 of 4 checks passed
@bsipocz bsipocz deleted the MAINT_post_jb2_cleanup branch October 25, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

html rendering / skip testing Rendering related issues/PRs. Skips tests in PRs. maintainance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants