Skip to content

Prevent GHA from running in forks #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent GHA from running in forks #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
jobs:

publish_html:
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'Caltech-IPAC/irsa-tutorials' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me investigate this one a bit more as normally we turn off fork-based runs within the on: section above rather than in individual conditionals (we don't even want this to trigger a skipped job).

(I didn't picked up on this bug as somehow jobs are not triggered on my own fork, but I see both you and Jaladh had them).

name: Publish HTML
runs-on: ubuntu-latest
steps:
Expand All @@ -46,7 +46,7 @@ jobs:
commit_message: ${{ github.event.head_commit.message }}

deploy_notebooks:
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'Caltech-IPAC/irsa-tutorials' }}
name: Deploy deployed_notebook branch
runs-on: ubuntu-latest
needs: publish_html
Expand All @@ -62,4 +62,4 @@ jobs:
git rm --cached -r .
git add --pathspec-from-file=deployed_notebooks_manifest.in --force
git commit -m "Deploy notebooks for commit ${gith}"
git push origin deployed_notebooks --force
git push origin deployed_notebooks --force
4 changes: 2 additions & 2 deletions .github/workflows/ci_tests_run_notebooks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ concurrency:
jobs:
tests:
# Do not run the test matrix on PRs affecting the rendering
if: ${{ !(github.event_name == 'pull_request') || !contains(github.event.pull_request.labels.*.name, 'html rendering / skip testing') }}
if: ${{ !(github.event_name == 'pull_request') || !contains(github.event.pull_request.labels.*.name, 'html rendering / skip testing') && github.repository == 'Caltech-IPAC/irsa-tutorials' }}

name: ${{ matrix.os }} ${{ matrix.name }}
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
gha_buildhtml:
# When label is used, we do run buildhtml on GHA to check if the publishing job will run or not.
# Use in case when new content has run into troubles on CircleCI.
if: ${{ (github.event_name == 'pull_request') && contains(github.event.pull_request.labels.*.name, 'GHA buildhtml') }}
if: ${{ (github.event_name == 'pull_request') && contains(github.event.pull_request.labels.*.name, 'GHA buildhtml') && github.repository == 'Caltech-IPAC/irsa-tutorials' }}
name: Buildhtml testing
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/circleci-artifacts-redirector.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Run CircleCI artifacts redirector for rendered HTML
on: [status]
jobs:
circleci_artifacts_redirector_job:
if: ${{ github.repository == 'Caltech-IPAC/irsa-tutorials' }}
runs-on: ubuntu-latest
name: Run CircleCI artifacts redirector
steps:
Expand Down