The World of Colour Update (aka 1.12) #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first PR in the series to not be backwards-compatible, and marks the start of 2.x.x.
Larry1123
reviewed
Jan 2, 2018
| */ | ||
| public Logman getLogman() { | ||
| return Logman.getLogman(getName()); | ||
| public Logger getLogger() { |
There was a problem hiding this comment.
This is not just likely to break all plugins but will 100% make all old plugins unable to be loaded.
There was a problem hiding this comment.
Yeah - Canary is going to start following semver, and this will be a major version bump, all plugins should expect to break.
There was a problem hiding this comment.
Are you on Telegram? Throw me your handle and I'll get you in chat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
This PR marks the beginning of CanaryLib 2.0 - plugins may well break
This PR is built off some work that I did way back in early 2016, in preparation for 1.10(?)
Changes
Since this PR will become CanaryLib 2.0.0, this PR will eventually address some of the following:
Logman, perhaps with slf4j?