Skip to content

Commit

Permalink
Remove s390x, powerpc64le from RELEASE_PLATFORMS
Browse files Browse the repository at this point in the history
- Release automation only creates amd64 binaries for darwin, linux, and
  windows.
- Continuous integration no longer runs on powerpc64le or s390x

Also remove stale build tags related to plugins and race detection for
old versions of go, s390x, and ppc64le.

Signed-off-by: Matthew Sykes <[email protected]>
  • Loading branch information
sykesm authored and Brett Logan committed May 29, 2020
1 parent adf7436 commit 330da90
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 18 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ GO_TAGS ?=

RELEASE_EXES = orderer $(TOOLS_EXES)
RELEASE_IMAGES = baseos ccenv orderer peer tools
RELEASE_PLATFORMS = darwin-amd64 linux-amd64 linux-ppc64le linux-s390x windows-amd64
RELEASE_PLATFORMS = darwin-amd64 linux-amd64 windows-amd64
TOOLS_EXES = configtxgen configtxlator cryptogen discover idemixgen peer

pkgmap.configtxgen := $(PKGNAME)/cmd/configtxgen
Expand Down
8 changes: 2 additions & 6 deletions bccsp/pkcs11/impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,17 +226,13 @@ func (csp *impl) Decrypt(k bccsp.Key, ciphertext []byte, opts bccsp.DecrypterOpt
// This is a convenience function. Useful to self-configure, for tests where usual configuration is not
// available
func FindPKCS11Lib() (lib, pin, label string) {
//FIXME: Till we workout the configuration piece, look for the libraries in the familiar places
lib = os.Getenv("PKCS11_LIB")
if lib == "" {
pin = "98765432"
label = "ForFabric"
possibilities := []string{
"/usr/lib/softhsm/libsofthsm2.so", //Debian
"/usr/lib/x86_64-linux-gnu/softhsm/libsofthsm2.so", //Ubuntu
"/usr/lib/s390x-linux-gnu/softhsm/libsofthsm2.so", //Ubuntu
"/usr/lib/powerpc64le-linux-gnu/softhsm/libsofthsm2.so", //Power
"/usr/local/Cellar/softhsm/2.5.0/lib/softhsm/libsofthsm2.so", //MacOS
"/usr/lib/softhsm/libsofthsm2.so", //Debian
"/usr/lib/x86_64-linux-gnu/softhsm/libsofthsm2.so", //Ubuntu
}
for _, path := range possibilities {
if _, err := os.Stat(path); !os.IsNotExist(err) {
Expand Down
1 change: 0 additions & 1 deletion core/chaincode/platforms/golang/platform.go
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,6 @@ func distributions() []dist {
// pre-populate linux architecutures
dists := map[dist]bool{
{goos: "linux", goarch: "amd64"}: true,
{goos: "linux", goarch: "s390x"}: true,
}

// add local OS and ARCH
Expand Down
2 changes: 0 additions & 2 deletions core/handlers/library/race_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
// +build race
// +build go1.9,linux,cgo go1.10,darwin,cgo
// +build !ppc64le

/*
Copyright IBM Corp. All Rights Reserved.
Expand Down
3 changes: 0 additions & 3 deletions core/handlers/library/registry_plugin_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
// +build go1.9,linux,cgo go1.10,darwin,cgo
// +build !ppc64le

/*
Copyright SecureKey Technologies Inc. All Rights Reserved.
Expand Down
5 changes: 0 additions & 5 deletions scripts/run-unit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,6 @@ run_tests_with_coverage() {
}

main() {
# explicit exclusions for ppc and s390x
if [ "$(uname -m)" == "ppc64le" ] || [ "$(uname -m)" == "s390x" ]; then
excluded_packages+=("github.com/hyperledger/fabric/core/chaincode/platforms/java")
fi

# default behavior is to run all tests
local -a package_spec=("${TEST_PKGS:-github.com/hyperledger/fabric/...}")

Expand Down

0 comments on commit 330da90

Please sign in to comment.