Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E -> Ea in creating-mechanisms.md #1853

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Fix E -> Ea in creating-mechanisms.md #1853

merged 1 commit into from
Feb 23, 2025

Conversation

rwest
Copy link
Member

@rwest rwest commented Feb 23, 2025

Changes proposed in this pull request

The instructions on writing YAML files said to use E for the activation energy, but all (but one of) the examples use Ea, which I think is correct. I updated the instructions and the one example that had E.

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

It said to use E for the activation energy, but all (but one of)
the examples use Ea.
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks good to me!

@ischoegl ischoegl merged commit d095f70 into Cantera:main Feb 23, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants