[MATLAB] Create MLTBX toolbox file that can be published on File Exchange #1882

ssun30 · 2025-05-07T23:42:47Z

Changes proposed in this pull request

Added a script to build the MLTBX toolbox file that can be published on File Exchange

If applicable, fill in the issue number this pull request is fixing

This addresses Task 6 from this enhancement proposal: Cantera/enhancements#226

If applicable, provide an example illustrating new features this pull request is introducing

The script will automatically package the relevant files, including data, interfaces/matlab_experimental, test\matlab_experimental, samples\matlab_experimental into the toolbox file.
Added a step in the CI to build the toolbox.
(WIP) The script should also be able to automatically download platform-specific Cantera binaries and header files (packaged in zip files) once we can automatically generate these files in our CI workflow.
(WIP) Add a step in the CI to test the toolbox.
(WIP) Add steps to upload the toolbox and host it somewhere.

Checklist

The pull request includes a clear description of this code change
Commit messages have short titles and reference relevant issues
Build passes (scons build & scons test) and unit tests address code coverage
Style & formatting of contributed code follows contributing guidelines
The pull request is ready for review

codecov · 2025-05-08T01:11:17Z

Codecov Report

❌ Patch coverage is 0% with 141 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.63%. Comparing base (1d63b0c) to head (6ec1f54).
⚠️ Report is 149 commits behind head on main.

Files with missing lines	Patch %	Lines
...nterfaces/matlab_experimental/Setup/buildToolbox.m	0.00%	60 Missing ⚠️
interfaces/matlab_experimental/Utility/ctPaths.m	0.00%	40 Missing ⚠️
...s/matlab_experimental/Setup/downloadDependencies.m	0.00%	21 Missing ⚠️
interfaces/matlab_experimental/Utility/ctLoad.m	0.00%	20 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
- Coverage   74.92%   72.63%   -2.29%     
==========================================
  Files         448      451       +3     
  Lines       55763    55885     +122     
  Branches     9205     9203       -2     
==========================================
- Hits        41780    40594    -1186     
- Misses      10881    12200    +1319     
+ Partials     3102     3091      -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bryanwweber

Given the note in the downloadDependencies.m file, I think this should probably wait until the setup is integrated into SCons and we figure out a release process.

interfaces/matlab_experimental/Setup/buildToolbox.m

bryanwweber · 2025-05-09T11:13:24Z

interfaces/matlab_experimental/Setup/buildToolbox.m

+    opts.OutputFile                      = outputFile;
+    opts.SupportedPlatforms.Win64        = true;
+    opts.SupportedPlatforms.Glnxa64      = true;
+    opts.SupportedPlatforms.Maci64       = true;


Does this support Apple Silicon?

MATLAB will run through Rosetta 2 on Apple Silicon for releases after R2020b so even though the option is called Maci64 it should support Apple Silicon.

Earlier releases will only support Mac with Intel processors.

Versions 2023b and up have native support … https://www.mathworks.com/support/requirements/apple-silicon.html

.github/workflows/main.yml

ischoegl · 2025-06-21T19:23:23Z

.github/workflows/main.yml

      - name: Set up MATLAB
        uses: matlab-actions/setup-matlab@718d4320188c73c86eb94ce76b553cbf89778487 # v2.5.0
+      - name: Set MATLAB search paths for tests and build MLTBX toolbox
+        uses: matlab-actions/run-command@v2


Please address this CI error by using a hash.

This should be addressed (see comment above).

ssun30 · 2025-06-14T00:43:28Z

Hi @bryanwweber @ischoegl , I have been testing my MLTBX toolbox with local copies of cantera binaries and headers. Could we build those and host them somewhere similar to the PyPI package?

bryanwweber · 2025-06-15T21:01:48Z

Yes, we can do that, but I'd prefer to wait until this package is ready to be built. What's the status here? You have some failing checks still

ischoegl · 2025-06-16T13:57:36Z

Yes, we can do that, but I'd prefer to wait until this package is ready to be built. What's the status here? You have some failing checks still

I second @bryanwweber’s opinion. I’d prefer to have a fully implemented test suite - there is a significant regression in the 1D code (#1722) that to my knowledge has not been addressed.

ischoegl

Thank you, @ssun30 - I only have minor comments. Other than that, I believe this is mostly ready to be merged - uploading to MATLAB File Exchange is an extra step and can be addressed at a later point.

.github/workflows/main.yml

ischoegl · 2025-06-21T19:23:23Z

.github/workflows/main.yml

      - name: Set up MATLAB
        uses: matlab-actions/setup-matlab@718d4320188c73c86eb94ce76b553cbf89778487 # v2.5.0
+      - name: Set MATLAB search paths for tests and build MLTBX toolbox
+        uses: matlab-actions/run-command@v2


Please address this CI error by using a hash.

bryanwweber · 2025-06-21T20:54:30Z

Aside from Ingmar's comments, I'm very confused about how all of the open PRs interact. For example, this PR changes test files but there's also the separate testing PR. Can you clarify the order we should review these?

the MLTBX file

and upload the artifact

for the MLTBX version

Replaced ctRoot with ctPaths, this will allow the user to set paths to the shared libraries, header files, and toolboxes more freely, instead of relying on relative paths to a fixed path for a certain conda environment.

to how paths are set

ischoegl · 2025-08-09T02:23:03Z

.github/workflows/main.yml

      - name: Set up MATLAB
        uses: matlab-actions/setup-matlab@718d4320188c73c86eb94ce76b553cbf89778487 # v2.5.0
+      - name: Set MATLAB search paths for tests and build MLTBX toolbox
+        uses: matlab-actions/run-command@v2


This should be addressed (see comment above).

ischoegl · 2025-08-09T12:56:59Z

[…] I'm very confused about how all of the open PRs interact. For example, this PR changes test files but there's also the separate testing PR. Can you clarify the order we should review these?

On a related note, I noticed that some of the same changes introduced here are also applied in #1911 (which I just reviewed). From a review perspective, it would be preferable to have single-purpose PRs so review comments can be properly tracked and addressed.

ischoegl · 2025-09-28T21:23:38Z

@ssun30 (and @rwest) ... looking over this PR again, I strongly believe that this aspect should be moved to a separate packaging repository, similar to Cantera/pypi-packages or conda-forge/cantera-feedstock. This will provide some flexibility for anything that is purely related to packaging and releasing.

From that perspective, I believe this PR should be closed.

ssun30 force-pushed the matlab_mltbx branch 2 times, most recently from 6768386 to 529e0e5 Compare May 7, 2025 23:52

ssun30 mentioned this pull request May 8, 2025

To-do List for releasing the MATLAB interface on File Exchange Cantera/enhancements#226

Open

7 tasks

ssun30 force-pushed the matlab_mltbx branch 2 times, most recently from 82f5f45 to f9ff4b1 Compare May 8, 2025 00:48

bryanwweber requested changes May 9, 2025

View reviewed changes

ischoegl added the Matlab label May 18, 2025

This was referenced May 30, 2025

Complete the experimental Matlab toolbox. Cantera/enhancements#177

Open

Address papercuts in generated CLib #1897

Merged

ssun30 force-pushed the matlab_mltbx branch from f9ff4b1 to 95c56a6 Compare June 11, 2025 04:43

github-advanced-security bot found potential problems Jun 11, 2025

View reviewed changes

.github/workflows/main.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jun 12, 2025

View reviewed changes

.github/workflows/main.yml Fixed Show fixed Hide fixed

ssun30 force-pushed the matlab_mltbx branch 2 times, most recently from 907bc96 to 6513c20 Compare June 12, 2025 01:58

github-advanced-security bot found potential problems Jun 12, 2025

View reviewed changes

ssun30 force-pushed the matlab_mltbx branch 2 times, most recently from 190fe92 to 32f8f53 Compare June 14, 2025 00:01

ischoegl reviewed Jun 21, 2025

View reviewed changes

ssun30 force-pushed the matlab_mltbx branch from 32f8f53 to d227c5b Compare July 1, 2025 18:37

ssun30 added 6 commits August 8, 2025 10:15

[MATLAB] Added the script to automatically build

a45584a

the MLTBX file

[MATLAB] Extra debugging info for buildToolbox

eb3d6ef

[MATLAB] Added CI step to build MLTBX

0dd3159

and upload the artifact

[MATLAB] CI now fetch latest tag for origin/main

f14f9aa

for the MLTBX version

[MATLAB] buildtoolbox now takes input arguments

ee36386

[MATLAB] Changed how search paths are set

8a9e3c8

Replaced ctRoot with ctPaths, this will allow the user to set paths to the shared libraries, header files, and toolboxes more freely, instead of relying on relative paths to a fixed path for a certain conda environment.

[MATLAB] Changed CI workflow to account for change

6ec1f54

to how paths are set

ssun30 force-pushed the matlab_mltbx branch from d227c5b to 6ec1f54 Compare August 8, 2025 14:16

ischoegl requested changes Aug 9, 2025

View reviewed changes

ischoegl closed this Sep 30, 2025

Uh oh!

[MATLAB] Create MLTBX toolbox file that can be published on File Exchange #1882

[MATLAB] Create MLTBX toolbox file that can be published on File Exchange #1882

Uh oh!

Conversation

ssun30 commented May 7, 2025

Uh oh!

codecov bot commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bryanwweber left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bryanwweber May 9, 2025

Choose a reason for hiding this comment

Uh oh!

ssun30 Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

ischoegl Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Check failure

ischoegl Jun 21, 2025

Choose a reason for hiding this comment

Uh oh!

ischoegl Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ssun30 commented Jun 14, 2025

Uh oh!

bryanwweber commented Jun 15, 2025

Uh oh!

ischoegl commented Jun 16, 2025

Uh oh!

ischoegl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ischoegl Jun 21, 2025

Choose a reason for hiding this comment

Uh oh!

bryanwweber commented Jun 21, 2025

Uh oh!

ischoegl Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ischoegl commented Aug 9, 2025

Uh oh!

ischoegl commented Sep 28, 2025

Uh oh!

Uh oh!

codecov bot commented May 8, 2025 •

edited

Loading

ischoegl Aug 9, 2025 •

edited

Loading

ischoegl Aug 9, 2025 •

edited

Loading