Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .claude/settings.local.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"permissions": {
"allow": [
"Bash(pnpm typecheck:*)",
"Bash(pnpm lint:*)",
"Bash(pnpm build:*)"
],
"deny": [],
"ask": []
}
}
"permissions": {
"allow": [
"Bash(pnpm typecheck:*)",
"Bash(pnpm lint:*)",
"Bash(pnpm build:*)",
"Bash(cargo check:*)"
],
"deny": [],
"ask": []
}
}
37 changes: 35 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions crates/enc-ffmpeg/src/audio/aac.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::time::Duration;
use std::{thread, time::Duration};

use cap_media_info::{AudioInfo, FFRational};
use ffmpeg::{
Expand Down Expand Up @@ -45,7 +45,10 @@ impl AACEncoder {
) -> Result<Self, AACEncoderError> {
let codec = encoder::find_by_name("aac").ok_or(AACEncoderError::CodecNotFound)?;
let mut encoder_ctx = context::Context::new_with_codec(codec);
encoder_ctx.set_threading(Config::count(4));
let thread_count = thread::available_parallelism()
.map(|v| v.get())
.unwrap_or(1);
encoder_ctx.set_threading(Config::count(thread_count));
let mut encoder = encoder_ctx.encoder().audio()?;

let rate = {
Expand Down
7 changes: 5 additions & 2 deletions crates/enc-ffmpeg/src/audio/opus.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::time::Duration;
use std::{thread, time::Duration};

use cap_media_info::{AudioInfo, FFRational};
use ffmpeg::{
Expand Down Expand Up @@ -43,7 +43,10 @@ impl OpusEncoder {
) -> Result<Self, OpusEncoderError> {
let codec = encoder::find_by_name("libopus").ok_or(OpusEncoderError::CodecNotFound)?;
let mut encoder_ctx = context::Context::new_with_codec(codec);
encoder_ctx.set_threading(Config::count(4));
let thread_count = thread::available_parallelism()
.map(|v| v.get())
.unwrap_or(1);
encoder_ctx.set_threading(Config::count(thread_count));
let mut encoder = encoder_ctx.encoder().audio()?;

let rate = {
Expand Down
7 changes: 5 additions & 2 deletions crates/enc-ffmpeg/src/video/h264.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::time::Duration;
use std::{thread, time::Duration};

use cap_media_info::{Pixel, VideoInfo};
use ffmpeg::{
Expand Down Expand Up @@ -99,7 +99,10 @@

let mut encoder_ctx = context::Context::new_with_codec(codec);

encoder_ctx.set_threading(Config::count(4));
let thread_count = thread::available_parallelism()
.map(|v| v.get())
.unwrap_or(1);
encoder_ctx.set_threading(Config::count(thread_count));
let mut encoder = encoder_ctx.encoder().video()?;

encoder.set_width(input_config.width);
Expand Down Expand Up @@ -139,7 +142,7 @@
pub struct H264Encoder {
base: EncoderBase,
encoder: encoder::Video,
config: VideoInfo,

Check warning on line 145 in crates/enc-ffmpeg/src/video/h264.rs

View workflow job for this annotation

GitHub Actions / Clippy

field `config` is never read

warning: field `config` is never read --> crates/enc-ffmpeg/src/video/h264.rs:145:5 | 142 | pub struct H264Encoder { | ----------- field in this struct ... 145 | config: VideoInfo, | ^^^^^^ | = note: `#[warn(dead_code)]` on by default
converter: Option<ffmpeg::software::scaling::Context>,
}

Expand Down
2 changes: 1 addition & 1 deletion crates/export/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ impl ExporterBuilder {
studio_meta.clone(),
)
.await
.unwrap(),
.map_err(Error::RendererSetup)?,
);

let segments = cap_editor::create_segments(&recording_meta, studio_meta)
Expand Down
4 changes: 2 additions & 2 deletions crates/export/src/mp4.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ impl Mp4ExportSettings {
info!("Exporting mp4 with settings: {:?}", &self);
info!("Expected to render {} frames", base.total_frames(self.fps));

let (tx_image_data, mut video_rx) = tokio::sync::mpsc::channel::<(RenderedFrame, u32)>(4);
let (frame_tx, frame_rx) = std::sync::mpsc::sync_channel::<MP4Input>(4);
let (tx_image_data, mut video_rx) = tokio::sync::mpsc::channel::<(RenderedFrame, u32)>(32);
let (frame_tx, frame_rx) = std::sync::mpsc::sync_channel::<MP4Input>(32);

Comment thread
Brendonovich marked this conversation as resolved.
Outdated
let fps = self.fps;

Expand Down
81 changes: 81 additions & 0 deletions crates/export/tests/export_benchmark.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
use std::{
path::PathBuf,
sync::{
Arc,
atomic::{AtomicU32, Ordering},
},
time::{Duration, Instant},
};
Comment thread
Brendonovich marked this conversation as resolved.

use cap_export::{
ExporterBase,
mp4::{ExportCompression, Mp4ExportSettings},
};
use cap_project::XY;
use cap_utils::list_recordings;

async fn run_export(project_path: PathBuf) -> Result<(PathBuf, Duration, u32), String> {
let exporter_base = ExporterBase::builder(project_path.clone())
.build()
.await
.map_err(|err| format!("Exporter build error: {err}"))?;

let settings = Mp4ExportSettings {
fps: 60,
resolution_base: XY::new(1920, 1080),
compression: ExportCompression::Minimal,
};

let start = Instant::now();
let last_frame = Arc::new(AtomicU32::new(0));
let frame_counter = Arc::clone(&last_frame);

let output_path = settings
.export(exporter_base, move |frame| {
frame_counter.store(frame, Ordering::Relaxed)
})
.await
.map_err(|err| format!("Exporter error: {err}"))?;

let elapsed = start.elapsed();
let frames = last_frame.load(Ordering::Relaxed);

if frames == 0 {
return Err("No frames were rendered during export".into());
}

Ok((output_path, elapsed, frames))
}

#[tokio::test(flavor = "multi_thread")]
#[ignore]
async fn export_latest_recording_benchmark() -> Result<(), Box<dyn std::error::Error>> {
let recordings = list_recordings();

println!("Found {} recordings", recordings.len());

if recordings.is_empty() {
return Err(
"No recordings found. Add a Cap recording before running this benchmark.".into(),
);
}

let Some(project_path) = recordings.first() else {
unreachable!("recordings list cannot be empty here");
};

println!("Using project: {}", project_path.display());

let (output_path, duration, frames) = run_export(project_path.clone()).await?;

let fps = frames as f64 / duration.as_secs_f64();
println!(
"Export completed in {:.2?} ({} frames, {:.2} fps). Output: {}",
duration,
frames,
fps,
output_path.display()
);

Ok(())
}
Loading
Loading